On Thu, Mar 28, 2019 at 9:24 AM Isuranga Perera <[email protected]> wrote:
> Hi, > > Increasing the column size is fine with most databases. However, Oracle > varchar datatype only allows a maximum of 4000 characters. Because of this > reason, we will be using an additional column to store the SAML2 assertion > as a Blob. Existing column will not be modified due to backward > compatibility reasons. > Increasing the column is not an elegant solution since we cannot predict the size of the SAML assertion. With the number of returned claims, it is always a gamble :) Therefore additional column to store the assertion looks good to me. > > There are three scenarios that can be affected by this implementation > > 1. IS 5.8.0 is used along with the modified database schema > 2. IS 5.8.0 is pointed to an old database where > IDN_SAML2_ASSERTION_STORE table doesn't have this additional column. In > this case, we will be checking if this additional column exists and act > accordingly. > 3. User migrate to the new version > > Is this the case where we would have both data in the old column (assertion stored before migration) as well as the new column (assertion created after migration)? > Best Regards > Isuranga Perera > > On Tue, Mar 26, 2019 at 12:49 PM Ruwan Abeykoon <[email protected]> wrote: > >> Hi Isuranga, >> There are two easy solutions for this. >> a) Use compression to store the text field on DB >> b) Increase the column size >> >> Both requires we do not have index for the respective column. >> >> Cheers, >> Ruwan A >> >> On Tue, Mar 26, 2019 at 12:45 PM Isuranga Perera <[email protected]> >> wrote: >> >>> Hi All, >>> >>> As observed in issue[1] SAML assertion is not persisted in SP-initiated >>> login as SAML assertion is larger than the column size(4096 in DB2) >>> specified in the schema. It is not just limited to DB2 as all other DBs has >>> a similar column size. Since "Assertion query request profile" feature is >>> already available in IS 5.7.0 this cannot be disabled. >>> >>> Appreciate your suggestions on the $subject. >>> >>> [1] https://github.com/wso2/product-is/issues/4776 >>> >>> Best Regards >>> Isuranga Perera >>> -- >>> *Isuranga Perera* | Software Engineer | WSO2 Inc. >>> +94 71 735 7034 | [email protected] <[email protected]> >>> >>> >> >> >> > > -- > *Isuranga Perera* | Software Engineer | WSO2 Inc. > +94 71 735 7034 | [email protected] <[email protected]> > > -- Farasath Ahamed Senior Software Engineer, WSO2 Inc.; http://wso2.com Mobile: +94777603866 Blog: blog.farazath.com Twitter: @farazath619 <https://twitter.com/farazath619> <http://wso2.com/signature>
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
