On Thu, Apr 11, 2019 at 3:33 PM Sathya Bandara <[email protected]> wrote:

> Hi all,
>
> Curently in AuthorizationCodeDAOImpl [1] and OAuthAppDAO we have the
> 'isPkceEnabled' flag to check the availability of PKCE columns during data
> persistence. This has been added to handle the migration scenarios. The
> PKCE feature was introduced with IS 5.2.0 and we already have 6 major
> releases after this version addressing the migration aspects. Therefore we
> have decided to remove this column check from the code level with 5.8.0 as
> it becomes redundant.
>
> Please share your thoughts and concerns on this.
>

Big +1


>
> [1]
> https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/master/components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/dao/AuthorizationCodeDAOImpl.java#L95
>
> Thanks,
> Sathya
> --
> Sathya Bandara
> Senior Software Engineer
> Blog: https://medium.com/@technospace
> WSO2 Inc. http://wso2.com
> Mobile: (+94) 715 360 421 <+94%2071%20411%205032>
>
> <+94%2071%20411%205032>
>


-- 
Farasath Ahamed
Senior Software Engineer, WSO2 Inc.; http://wso2.com
Mobile: +94777603866
Blog: https://farasath.blogspot.com / https://medium.com/@farasath
Twitter: @farazath619 <https://twitter.com/farazath619>
<http://wso2.com/signature>
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to