Hi Sherene/Darshana, I created a pull request with the changes. Please review and merge it.
Cheers, Isura [1] https://github.com/IsuraD/docs-is/pull/1 On Thu, Aug 1, 2019 at 12:23 PM Darshana Gunawardana <[email protected]> wrote: > > On Thu, Aug 1, 2019 at 11:32 AM Sherene Mahanama <[email protected]> wrote: > >> Hi, >> >> As discussed offline, since there is no identity.xml.j2 file in 5.8.0, I >> have not updated the 5.8.0 doc [1]. >> > > Yes.. Both of the issues reported by Gayashan, only affected to IS 5.9.0.. > > >> It would be good if it's possible to add this to the file by default in >> 5.9.0.. else, please let me know and I will update the 5.9.0 doc [2]. >> > > IMO, in one angle, default configs should be production-ready ones, so we > cannot have custom web apps to be allowed by default in the identity.xml... > On the other hand, we should improve the user experience of the person who > tries the guide by having minimal changes. > > This is a place we can utilize "dev" or new profile like "poc" or > "samples" with the new config model. > > For the moment, let's add this config to the 5.9.0 docs and then decide > whether we can utilize a new config profile to simplify configurations of > samples and use that. > > Thanks, > >> >> [1] >> https://docs.wso2.com/display/IS580/Configuring+a+Service+Provider+for+Adaptive+Authentication#ConfiguringaServiceProviderforAdaptiveAuthentication-Step01:SetUptheSamples >> [2] >> https://is.docs.wso2.com/en/5.9.0/tutorials/configuring-a-service-provider-for-adaptive-authentication >> >> Thanks, >> Sherene >> >> On Wed, Jul 31, 2019 at 3:42 PM Isura Karunaratne <[email protected]> wrote: >> >>> Hi Sherene, Yvonne, >>> >>> In order to fix [1], we need to update the document [2]. It is required >>> to add the following configuration in >>> <IS_HOME>/repository/resources/conf/templates/repository/conf/identity.xml.j2 >>> as instructed in [1]. >>> >>> *<Resource context="/sample-auth(.*)" secured="false" >>> http-method="all"/>* >>> >>> Please update the [2] by adding a new step. >>> >>> Cheers, >>> Isura. >>> >>> [1] https://github.com/wso2/product-is/issues/6023 >>> [2] >>> https://docs.wso2.com/display/IS580/Configuring+a+Service+Provider+for+Adaptive+Authentication#ConfiguringaServiceProviderforAdaptiveAuthentication-Step01:SetUptheSamples >>> >>> On Tue, Jul 30, 2019 at 2:57 PM Darshana Gunawardana <[email protected]> >>> wrote: >>> >>>> [Looping Isura] >>>> >>>> >>>> On Tue, Jul 30, 2019 at 2:55 PM Darshana Gunawardana <[email protected]> >>>> wrote: >>>> >>>>> Hi Gayashan, >>>>> >>>>> Please see my comments below. >>>>> >>>>> On Tue, Jul 30, 2019 at 2:23 PM Gayashan Bombuwala <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi All, >>>>>> >>>>>> I came across the following issues when trying out the Role Based >>>>>> Adaptive Authentication example >>>>>> <https://docs.wso2.com/display/IS580/Configuring+Role-Based+Adaptive+Authentication> >>>>>> . >>>>>> >>>>>> >>>>>> 1. #6022 <https://github.com/wso2/product-is/issues/6022> - >>>>>> UsernameJavaScriptRegEx property configuration in usr-mgt.xml has been >>>>>> changed. >>>>>> >>>>>> We have to fix in the default config to avoid any configuration >>>>> changes during the guide. >>>>> >>>>>> >>>>>> 1. >>>>>> 2. #6023 <https://github.com/wso2/product-is/issues/6023> - >>>>>> Unauthorized error while following the "Role Based Adaptive >>>>>> Authentication" >>>>>> example. >>>>>> >>>>>> This has to capture in docs. >>>>> >>>>> Thanks, >>>>> >>>>>> >>>>>> 1. >>>>>> >>>>>> >>>>>> Best Regards >>>>>> >>>>>> -- >>>>>> *Gayashan Bombuwala* >>>>>> Software Engineer | WSO2 >>>>>> >>>>>> Email: [email protected] >>>>>> Phone: +94770548334 >>>>>> >>>>>> [image: https://wso2.com/signature] <https://wso2.com/signature> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Regards, >>>>> >>>>> >>>>> *Darshana Gunawardana*Technical Lead >>>>> WSO2 Inc.; http://wso2.com >>>>> >>>>> *E-mail: [email protected] <[email protected]>* >>>>> *Mobile: +94718566859*Lean . Enterprise . Middleware >>>>> >>>> >>>> >>>> -- >>>> Regards, >>>> >>>> >>>> *Darshana Gunawardana*Technical Lead >>>> WSO2 Inc.; http://wso2.com >>>> >>>> *E-mail: [email protected] <[email protected]>* >>>> *Mobile: +94718566859*Lean . Enterprise . Middleware >>>> >>> >>> >>> -- >>> >>> *Isura Dilhara Karunaratne* >>> Technical Lead | WSO2 <http://wso2.com/> >>> *lean.enterprise.middleware* >>> Email: [email protected] >>> Mob : +94 772 254 810 >>> Blog : https://medium.com/@isurakarunaratne >>> >>> >>> >>> >> >> -- >> Sherene Mahanama >> Senior Technical Writer >> >> WSO2 (pvt.) Ltd. >> Colombo, Sri Lanka >> Mobile: (+94) 777 <%28%2B94%29%20773131798> >> *994805* >> > > > -- > Regards, > > > *Darshana Gunawardana*Technical Lead > WSO2 Inc.; http://wso2.com > > *E-mail: [email protected] <[email protected]>* > *Mobile: +94718566859*Lean . Enterprise . Middleware > -- *Isura Dilhara Karunaratne* Technical Lead | WSO2 <http://wso2.com/> *lean.enterprise.middleware* Email: [email protected] Mob : +94 772 254 810 Blog : https://medium.com/@isurakarunaratne
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
