Hi Gary, [X] DONE :)
-> https://issues.apache.org/jira/browse/XALANJ-2578 Please let me know what you think of the patch; the description from the previous email is also attached to the Jira issue. Uwe On Wed, Mar 12, 2014 at 12:18 AM, Gary Gregory garydgregory-at-gmail.com |xalan.apache.org/Allow_neo-media| <[email protected]> wrote: > Uwe, > > Could you create a Jira ticket here > http://issues.apache.org/jira/browse/XALANJ and attach your patch? My > understanding is that by doing so you are going through the proper hoops for > us to safely apply the patch WRT licensing/copyright but IANAL. > > Gary > > > On Tue, Mar 11, 2014 at 3:38 AM, <[email protected]> wrote: >> >> Hi there, >> >> I've attached a patch for the xalan-J trunk which adds Maven POM >> files. The additions attempt to be non-intrusive, leaving the existing >> ant build system untouched. For this reason, the POMs are not as lean >> as they could be (see below). >> >> I've run the minitest suite ('ant smoketest.gump'), and it all works >> fine on a fresh checkout. >> >> This patch is intended as a basis for discussion, as there are still a >> few questions open: >> >> * Will this replace the ant build? (preferably yes, we could make the >> POMs much leaner by moving sources into standard Maven directories; >> less maintenance) >> * What will be the target version number? (see below for details) >> * How do we integrate testing? (it's currently in a separate project, >> and that's a good thing - but running it from Maven would be nice) >> >> Overview >> ======== >> >> There is a project parent POM, which groups the project into the >> following modules: >> * serializer (builds serializer.jar, from the >> org.apache.xml.serializer.* packages) >> * xalan-impl (builds an intermediate jar from the rest of the sources) >> * xalan (builds xalan.jar, using the maven shade plugin to integrate >> xalan-impl and dependent libraries into an uber-jar - this replicates >> the output of the ant build process) >> >> Output artifacts (xalan.jar and serializer.jar) are placed in the >> 'build' directory, like in the ant build. The groupId and artifactId >> are the same as the ones in Maven Central for Xalan-J 2.7.1 >> >> Details >> ======= >> >> In the Maven build, dependent libraries (BCEL, java_cup, regexp) are >> pulled from Maven Central and differ slightly in version from what's >> checked into SVN in the lib-directory. >> The same goes for the tools directory; the Maven tooling uses >> artifacts from Maven central and ignores the tools directory >> altogether. >> >> Since the versioning scheme in the project differs from standard Maven >> versioning (2.7.D2 for a defelopment version of 2.7.2 vs its Maven >> equivalent 2.7.2-SNAPSHOT), I've left it with Maven standard for now. >> The current version in the POMs is set to 2.8-SNAPSHOT, as I'd expect >> a change like this to go into a minor release rather than a bugfix >> release. >> >> Because the versioning question is still open, the POMs leave >> Version.java in both serializer.jar and xalan.jar alone. Depending on >> what we decide to do with project versioning and whether or not we >> preserve the ant build (preferably no), the way the Version classes >> operate will need to change (either read the version from a generated >> property file, read it from META-INF or use Maven filtering). >> Currently, the ant build simple overwrites them and removes them on >> clean (even though they're checked in). >> >> Cheers, >> >> Uwe >> >> >> On Fri, Feb 28, 2014 at 2:47 PM, Gary Gregory >> garydgregory-at-gmail.com |xalan.apache.org/Allow_neo-media| >> <[email protected]> wrote: >> > That sounds good, I'd like to see a RAT report, FindBugs, PMD and so on. >> > >> > Gary >> > >> > >> > On Wed, Feb 26, 2014 at 2:33 AM, <[email protected]> wrote: >> >> >> >> Hi all, >> >> >> >> Is there interest to use Maven as build system for Xalan in the future? >> >> If >> >> yes, I'm willing to donate the changes required (I've already got a >> >> fair bit >> >> of that done). >> >> >> >> Regards, >> >> >> >> Uwe Pachler >> > >> > >> > >> > >> > -- >> > E-Mail: [email protected] | [email protected] >> > Java Persistence with Hibernate, Second Edition >> > JUnit in Action, Second Edition >> > Spring Batch in Action >> > Blog: http://garygregory.wordpress.com >> > Home: http://garygregory.com/ >> > Tweet! http://twitter.com/GaryGregory >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] > > > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > JUnit in Action, Second Edition > Spring Batch in Action > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
