[
https://issues.apache.org/jira/browse/XALANJ-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Kesselman updated XALANJ-2653:
----------------------------------
Description:
Code cleanliness, though this may subsume XALANJ-2652
As currently structured, xalan-test is usually dividing testlet types by
directory.
For example, the accept bucket's tests are all {_}StylesheetTestlet{_}s; their
input files (.xsl and .xml) live in subdirectories of {*}tests/accept{*}, with
"gold files" (which the output is verified against) living in corresponding
{*}tests/accept-gold{*}. The *build.xml* Ant script runs only
_*StylesheetTestletDriver*_ for this bucket, so code-based tests (typically API
tests or tests which require more explicit validation of their output) can not
be intermixed with these. This is by far our most common pattern.
At the other extreme, the ad-hoc *tests/bugzilla* and *tests/jira* buckets
support a mixture of {_}StylesheetTestlet{_}s and Java code based
{_}*TestletImpl*{_}s, using a custom *_TestletDriver_* for each of these
buckets, and keeping all the input, gold, and code files in the single bucket
directory.
Ideally, I'd like to see this restructured so all the bucket directories
support the same structure, and all support both by-example _StylesheetTestlet_
and by-code {_}*TestletImpl*{_}{_}.{_} That would facilitate moving
issue-associated examples from the *bugzilla/jira* buckets to the appropriate
category as regression tests, and/or to *tests/contrib* if we consider them
worth saving but not worth running as part of smoketest.
This may be as simple as reworking _*BugzillaTestlet/JiraTestlet*_ to follow
the same directory structure as _StylesheetTestlets,_ and invoking both kinds
of _*TestletDriver*_ against directories which contain both – or having a
wrapper driver which runs that combination.
> Test driver issue: Permit intermixed stylesheet and java testlets, in a more
> organized manner than the bugzilla and jira directories
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: XALANJ-2653
> URL: https://issues.apache.org/jira/browse/XALANJ-2653
> Project: XalanJ2
> Issue Type: Bug
> Security Level: No security risk; visible to anyone(Ordinary problems in
> Xalan projects. Anybody can view the issue.)
> Reporter: Joe Kesselman
> Assignee: Gary D. Gregory
> Priority: Major
>
> Code cleanliness, though this may subsume XALANJ-2652
> As currently structured, xalan-test is usually dividing testlet types by
> directory.
> For example, the accept bucket's tests are all {_}StylesheetTestlet{_}s;
> their input files (.xsl and .xml) live in subdirectories of
> {*}tests/accept{*}, with "gold files" (which the output is verified against)
> living in corresponding {*}tests/accept-gold{*}. The *build.xml* Ant script
> runs only _*StylesheetTestletDriver*_ for this bucket, so code-based tests
> (typically API tests or tests which require more explicit validation of their
> output) can not be intermixed with these. This is by far our most common
> pattern.
> At the other extreme, the ad-hoc *tests/bugzilla* and *tests/jira* buckets
> support a mixture of {_}StylesheetTestlet{_}s and Java code based
> {_}*TestletImpl*{_}s, using a custom *_TestletDriver_* for each of these
> buckets, and keeping all the input, gold, and code files in the single bucket
> directory.
> Ideally, I'd like to see this restructured so all the bucket directories
> support the same structure, and all support both by-example
> _StylesheetTestlet_ and by-code {_}*TestletImpl*{_}{_}.{_} That would
> facilitate moving issue-associated examples from the *bugzilla/jira* buckets
> to the appropriate category as regression tests, and/or to *tests/contrib* if
> we consider them worth saving but not worth running as part of smoketest.
> This may be as simple as reworking _*BugzillaTestlet/JiraTestlet*_ to follow
> the same directory structure as _StylesheetTestlets,_ and invoking both kinds
> of _*TestletDriver*_ against directories which contain both – or having a
> wrapper driver which runs that combination.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
