jkesselm commented on PR #2:
URL: https://github.com/apache/xalan-java/pull/2#issuecomment-1591471554
Hm. Digressing, and apologies for playing catch-up here if the answer is
"tried, can't", but... Have we tested with the newer java_cup release? Unless
we have a specific reason for staying with a back level version, the usual
Maven philosophy would be that we at least try to stay with current code,
updating our own code to track it if necessary... "At least version X" is
preferred to exact version unless there's a known issue.
The same would apply to JLex; if there's a way to avoid needing a copy which
is both backdated and modified, we should consider that.
I presume we know what the modification was, it's not just that we have
previous version of JLex (it doesn't announce version number), and it's too
messy to apply programmatically do a downloaded copy?
--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() Plaintext Ribbon Campaign
/\ Stamp out HTML mail!
________________________________
From: Vladimir Sitnikov ***@***.***>
Sent: Wednesday, June 14, 2023 1:53:40 AM
To: apache/xalan-java ***@***.***>
Cc: Joe Kesselman ***@***.***>; Comment ***@***.***>
Subject: Re: [apache/xalan-java] Improve build: add CI, run xalan-test in
CI, download jars from Central (PR #2)
wouldn't be the right answer for JLex, fetching
https://www.cs.princeton.edu/~appel/modern/java/JLex/Archive/1.2.6/Main.java or
whichever other specific release is desired.
Please read #2
(comment)<https://github.com/apache/xalan-java/pull/2#issuecomment-1196656754>
Apparently, JLex.jar within xalan-java is modified, so there's no way to
fetch a pre-built jar.
I would suggest integrating JLex in a source form, and building it during
xalan build, however, it would be too many changes for the current PR which
focuses on adding CI.
But it appears to be equivalent to the risk for java_cup.
xalan-java uses java-cup version 11b or something like that.
That version is not available on Central, so the only way to download it is
to fetch from the project webpage and/or ask the maintainers to publish on
Central.
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/xalan-java/pull/2#issuecomment-1590515508>, or
unsubscribe<https://github.com/notifications/unsubscribe-auth/A7OJ6WYZM27WJ6D5ABLQXTLXLFGWJANCNFSM54RHYSIA>.
You are receiving this because you commented.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
