jkesselm opened a new pull request, #101: URL: https://github.com/apache/xalan-java/pull/101
Please review this carefully, and test thoroughly. I have been figuring out Maven as I went, and I'm sure some parts of this are not idiomatic, or not as elegant as they should be. CAVEAT: Some things wind up in different places than they did in the Ant build. If that bothers folks we can do more work to resolve it, but I think what I haven't already fixed is mostly harmless. SUMMARY OF CHANGES: Restructures serializer, xalan, and samples as sub-modules with dependencies on each other. Adds packages to the samples, and fixes some javadoc (see below), but otherwise the actual Java logic should be unaltered. JavaCupRedirect is no longer needed; we might want to review for other dead code. Avoids carrying binaries in the project; fetch from Maven Central, or (in the case of the Javadoc taglet) carry the source in our own project. As part of that, eliminates dependencies on outdated versions of some of these, specifically java_cup and jlex. JFlex has replaced JLex, which permitted/required handling the look-ahead cases in the grammer rather than by reading ahead via code. Reworks "site" (documentation) generation. Some files may be landing in diffrent locations in the resulting directory tree; if that's an issue, it can be fine-tuned. Some javadoc errors were (sloppily) fixed before discovering that I can turn off "doclint" and let them continue to be warnings rather than build errors; these should be fixed properly at some point (in many cases by switching to using javadoc inheritance). Some files were converted from HTML to XHTML, since Maven's doc plugin knows how to handle the latter. On Windows, javadoc needed javax.rmi as an explicit dependency. TODO: We still have some StyleBook files as well, mostly for the design documentation. I'm handling those with a "stylebook_docgen" script for now, invoked from the mvnbuild script/batch file; that should be moved into the pom's logic. NOT YET DONE: More of the non-Java files may want to be moved into resource subdirectories. NOT YET DONE: xalan-test should probably be moved into the Xalan project to facilitate testing during continuous integration, especially if it's no longer in use outside Xalan. First thing to do would be to mavenize that, which would probably require reworking the test drivers from Ant plugins to something Maven-compatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
