jkesselm commented on PR #123: URL: https://github.com/apache/xalan-java/pull/123#issuecomment-1813785560
The build directory isn't target. It's the point at which the behavior of this Maven should result in the same artifacts as the old Ant. As such it is both proof of success, and the point at which other builds -- specifically the test suite -- interact with this one when run in the same directory space. Technically I should indeed be producing the assemblies in target and then copying them to build as an afterthought. I have found copying to be overly complicated, though, which has inclined me toward writing the assemblies directly to build for now. Making the copying yet another dependent module might work, but ugh... that's staring to become uglier than make files (though admittedly more portable, which combined with the repository is what's kept me trying to wrap my head around Maven.) build/ will become less necessary after we have gotten past Maven-build acceptance and started reworking the tests into a Maven-nativeish form. But for now, we need it if we want people to be convinced we haven't broken anything. My assembly *should* be excluding build, exactly as it excluded target. If it isn't, I'll fix that. > > There's already more change in this than I had hoped. > > Do you mean in the migration branch in general or specifically in this PR? Migration in general. And yes, I too am hoping we can merge soon. Getting feedback from you about how Maven wants to think about things has been hugely helpful; if I can just get the distribution zips to the point where they're equivalent to the Ant versions (modulo deliberate restructuring into modules and some dependency updates), and rerun regression tests on the jars with version number stripped off them, I'm just about ready to pull the trigger. I would prefer to walk through the maven build with Gary G. before cutting over, to get one more pair of eyes on it, but I wanted to get it at least metastable before trying to get on his calendar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
