vlsi commented on code in PR #137:
URL: https://github.com/apache/xalan-java/pull/137#discussion_r1413054598
##########
xalan/src/test/java/org/apache/xalan/VersionTest.java:
##########
@@ -59,41 +85,47 @@ public void testCannotReadProperties() {
.when(Version::getPropertiesStream)
.thenThrow(NullPointerException.class);
assertEquals("0.0.0", Version.readVersionNumber());
+ assertTrue(buffer.toString().contains("RuntimeException: Cannot read
properties file"));
Review Comment:
`PrintStream` might buffer results so you probably want to add
`mockPrintStream.flush()` before `buffer.toString()` (there are multiple uses
of `buffer.toString()`, and it looks like all of them need adjustments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
