Don't wait for me, I happy to look at the code wherever it is. Gary
On Fri, Dec 29, 2023, 9:20 PM Joseph Kesselman <[email protected]> wrote: > Sorry. Gary, but as far as I can see it isn't "free" when starting with an > large existing set of conformance tests with custom drivers, some of which > are written as ant tasks, checked in as a separate tool not exclusive to > Xalan and not itself retrievable in ready to run form thru Maven. > > The fact that those tests still involve bootclasspath overrides doesn't > help. I started fixing that but it was distracting me from finishing the > Maven build. > > We _can_ make the Maven build fetch the tests from git and invoke their > ant-driven build and execution. And we may have to do so if you want the > test framework to always ship with the distro build. > > Of course we can take that as technical debt to be resolved before we can > do an actual release using Maven build, and pull the trigger on merge soon > (I still need to do some manual merging to rebase my branch). Critical > fixes can be done by back-porting then to the ant-based maintenance branch > and releasing from there. > > This is seriously getting to "if you want to review this before I merge, > it needs to be done _soon_." Otherwise I think we want to merge and then > polish. I want this pass closed out, darn it; it's already taken much too > long. > > > -- > /_ Joe Kesselman (he/him/his) > -/ _) My Alexa skill for New Music/New Sounds fans: > / https://www.amazon.com/dp/B09WJ3H657/ > > Caveat: Opinionated old geezer with overcompensated writer's block. May > be redundant, verbose, prolix, sesquipedalian, didactic, officious, or > redundant. > ------------------------------ > *From:* Gary Gregory <[email protected]> > *Sent:* Friday, December 29, 2023 6:54:40 PM > *To:* [email protected] <[email protected]> > *Subject:* Re: Policy question re src distribution > > IMO the source zip should include the tests. If I build from first > principles (and maybe patch on top of that), how do I know if I've built > something valid? Or introduced one small bug? > > I have to apologize for not having kept up on the Maven build. This is > something you get for "free" when your project is organized in the standard > Maven folder layout and you use the Maven Assembly plugin. I'll have to > take some time this weekend and look... ;-) > > Gary > > On Fri, Dec 29, 2023, 5:38 PM Joseph Kessselman <[email protected]> > wrote: > > In the past, the src tarball/zipfile has included an embedded copy of > xalan-test, for the convenience of anyone downloading source who wanted > to confirm that their build had succeeded. > > Should the maven src distro do the same, despite xalan-test being ... > oddly ... integrated and still building with ant? > > Or should xalan-test have its own distros? > > Or something else? > > (I'd rather not recreate the embedding of xalan-test's source, but it > wouldn't be impossible, just ugly.) > > -- > ` /_ Joe Kesselman (he/him/his) > -/ _) My Alexa skill for New Music/New Sounds fans: > / https://www.amazon.com/dp/B09WJ3H657/ > Caveat: Opinionated old geezer with overcompensated writer's block. May > be redundant, verbose, prolix, sesquipedalian, didactic, officious, or > redundant. Feel free to call him on it. > >
