Hi Adam,
I've been looking at this but still have problems with the nillable stuff, but your example below breaks the semantics. You stated in your other email:

We still need the 2 different properties in order to tell what is ALLOWED to be Nillable (nullable) from what the user would LIKE to be Nillable (nillable).

But in your snippet below, you're reversing those semantics. setNullable(false) doesn't mean in that case that Date isn't allowed to be Nillable, its just what the user would like. You follow?

The real issue here is how do we know that a user hasn't overridden the nillable property on the type. For instance, say I create some custom type which I want to be nillable but set the nillable default to false. The patch will overwrite that property since there is no way to override it. Or the other way around - I set a specific type's nillability to false but set the global default to true. Once again it gets overridden.

I'm not sure there is a simple solution for this, but I'm up for ideas...

- Dan

Adam Chesney wrote:
Hi Dan,

Any idea when you will get a chance to integrate my updated patches?

http://jira.codehaus.org/browse/XFIRE-295?page=all

Then add:

public DateType()
{
   setNullable(false);
}

to DateType.java

Cheers,

Adam.


----- Original Message ----- From: "Adam Chesney" <[EMAIL PROTECTED]>
To: <[email protected]>
Sent: Thursday, March 16, 2006 4:21 PM
Subject: Re: [xfire-dev] [jira] Updated: (XFIRE-295) optionally add xs:any & xs:anyAttribute to complex types produced by Aegis WSDL builder


Hi Dan,

Ok well if dates can never be nillable then just override:

public booean isNullable()
{
   return false;
}

in DateType.java, or alternatively call:

public DateType()
{
   setNullable(false);
}

in the constructor.

This will mean that it will never come out as Nillable="true" even if the default for Nillable is true. Which it is.

Repeat for any other types that cannot be Nilled.

We still need the 2 different properties in order to tell what is ALLOWED to be Nillable (nullable) from what the user would LIKE to be Nillable (nillable).

Cheers,

Adam.

--
Dan Diephouse
Envoi Solutions
http://envoisolutions.com
http://netzooid.com/blog

Reply via email to