[ http://jira.codehaus.org/browse/XFIRE-401?page=comments#action_81407 ] 
            
Philippe Jacot commented on XFIRE-401:
--------------------------------------

I tried the 1.2.3 version of maven-core today (found it on 
http://repository.codehaus.org/), and this issue doesn't seem to be fixed. 
Looking at the the code of 
org/codehaus/xfire/transport/http/CommonsHttpMessageSender.java I think the 
problem is on line 269, there should be a newline in front of "return false; }"

                259     +           private boolean isNonProxyHost( String 
strURI, MessageContext context ) 
                260     +           {
                261     +               // convert String based URI into a URI 
class based URI ...
                262     +               URI uri = null;
                263     +               try
                264     +               {
                265     +                   uri = new URI(strURI);
                266     +               }
                267     +               catch (URISyntaxException use)
                268     +               { // this should actually not happen, 
but just
                269     +                   // in case. return false; }
                270     +                   // ... get a system platform 
ProxySelector, and ...
                271     +                   ProxySelector ps = 
ProxySelector.getDefault();
                272     +                   // ... let this selector return a 
list of proxies.
                273     +                   List proxies = ps.select(uri);
                274     +                   // If that lists sole element is of 
type Proxy.NO_PROXY
                275     +                   // then we need a direct 
connection, otherwise we need to connect
                276     +                   // through a proxy.
                277     +                   if (proxies.size() == 1 && 
proxies.get(0).equals(Proxy.NO_PROXY))
                278     +                   {
                279     +                       return true;
                280     +                   }
                281     +               }
                282     +               return false;
                283     +           }

> Recognize the Java runtime system variable for HTTP proxies
> -----------------------------------------------------------
>
>                 Key: XFIRE-401
>                 URL: http://jira.codehaus.org/browse/XFIRE-401
>             Project: XFire
>          Issue Type: Improvement
>    Affects Versions: 1.1-RC1
>         Environment: N/A
>            Reporter: Stefan Freyr Stefansson
>         Assigned To: Tomasz Sztelak
>             Fix For: 1.2.3
>
>
> Currently it seems that the only way to specify a proxy for an XFire client 
> is by doing it programatically when creating the client:
>       MySoap client = stub.getMySoap();
>       Client http = ((XFireProxy) 
> Proxy.getInvocationHandler(client)).getClient();
>       http.setProperty(CommonsHttpMessageSender.HTTP_PROXY_HOST, "localhost");
>       http.setProperty(CommonsHttpMessageSender.HTTP_PROXY_PORT, "8080");
> This means that if you want to be able to transparently set a proxy you'll 
> have to code some logic to check whether a property is set everywhere you 
> create a client. A much more convenient way would be if the generated code 
> from XFire took into account the standard Java environment properties for 
> setting a proxy (as documented here: 
> http://java.sun.com/j2se/1.5.0/docs/guide/net/properties.html). This would 
> provide much convenience and flexibility in how to set whether or not to use 
> an HTTP proxy as explained here: 
> http://www.rgagnon.com/javadetails/java-0085.html.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to