apache-yetus commented on issue #43: YETUS-688. convert key globals from 
strings to arrays
URL: https://github.com/apache/yetus/pull/43#issuecomment-462108281
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 44 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 5 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 81 | master passed |
   | +1 | compile | 8 | master passed |
   | +1 | javadoc | 10 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 10 | the patch passed |
   | +1 | compile | 8 | the patch passed |
   | +1 | javac | 8 | the patch passed |
   | +1 | shellcheck | 12 | There were no new shellcheck issues. |
   | +1 | shelldocs | 2 | There were no new shelldocs issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 1 | The patch has no ill-formed XML file. |
   | +1 | javadoc | 8 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 8 | precommit in the patch passed. |
   | +1 | asflicense | 8 | The patch does not generate ASF License warnings. |
   | | | 224 | |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/yetus-github-multibranch/job/PR-43/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/yetus/pull/43 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile 
shellcheck shelldocs |
   | uname | Linux cdb00d0739e7 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | precommit/src/main/shell/personality/yetus.sh |
   | git revision | master / 9a2b130 |
   | maven | version: Apache Maven 3.3.9 |
   | Default Java | 1.8.0_191 |
   | shellcheck | v0.4.6 |
   |  Test Results | 
https://builds.apache.org/job/yetus-github-multibranch/job/PR-43/3/testReport/ |
   | Max. process+thread count | 98 (vs. ulimit of 2000) |
   | modules | C: precommit U: precommit |
   | Console output | 
https://builds.apache.org/job/yetus-github-multibranch/job/PR-43/3/console |
   | Powered by | Apache Yetus 0.10.0-SNAPSHOT http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to