-1
In addition to some harmless curl output that was inadvertently left in, at $DAYJOB we hit three issues on a particularly complicated build (multiple repos checked out, multiple GitHub credentials involved, Jenkins shared libraries, ... basically all the things): * if GITHUB_REPO isn't properly defined or auto-discovered but the GitHub plug-in is enabled, all hell breaks loose and the user has no idea why. * For source trees with thousands of problems, performance just dies in the GitHub Checks Annotations REST calls that makes you think everything fell apart. I clearly need to enforce a limit here. Sending them all is not viable. * Non-GitHub Actions annotations don't have the plug-in where they came from. Users found that very confusing in some circumstances because the context was helpful, especially for systems like golangci-lint vs. revive. On the plus side, using Docker's BuildKit has definitely been noticeable for our multi-stage Dockerfiles. Luckily, these are all relatively easy fixes so I should have a patch later today. It'd be great if someone who still works on ASF builds could still go ahead and test this RC sooner rather than later. Thanks.
