Sorry for such a tardy reply. If the user has specified a PR target for the build, I think it will be surprising to switch to a branch build. I have also experienced the frustration of "why doesn't it understand this PR target... oh wait, my credentials are not present/need elevated." I'd much prefer an error message that reminds me to check that the credentials are present and have necessary privileges.
Thanks, Nick On Tue, May 2, 2023 at 6:57 PM Allen Wittenauer <a...@apache.org> wrote: > > > Some CI systems (e.g., Circle CI) does not automatically provide a Github > token. Would it make sense to switch to branch builds when: > > * The build is determined to be from a PR > * The PR pull fails > > Obviously a warning should be given to tell the user _why_ it switched. > For existing users this change might be unexpected but overall it feels > more ‘friendly’ to do as it could hit that “Yetus is fine; your setup is > not.” I know it took _me_ a bit to realize what was wrong.
