wilfred-s commented on a change in pull request #77: Recovery times out if the
cluster initially has no nodes
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/77#discussion_r381059628
##########
File path: pkg/cache/context_recovery.go
##########
@@ -205,12 +205,11 @@ func waitAndListPods(lister v1.PodLister)
([]*corev1.Pod, error) {
func waitAndListNodes(lister v1.NodeLister) ([]*corev1.Node, error) {
var allNodes []*corev1.Node
+ var listErr error
err := utils.WaitForCondition(func() bool {
//nolint:errcheck
Review comment:
This lint comment should be removed as we now check the err
why is the declaration of listErr outside of the function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
