yangwwei commented on a change in pull request #81: [YUNIKORN-28] Support
validating yunikorn-configs before admitting it
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/81#discussion_r393372123
##########
File path: deployments/admission-controllers/scheduler/generate-signed-ca.sh
##########
@@ -24,8 +24,8 @@ if [ ! -f ${CONF_FILE} ]; then
fi
tmpdir="$1"
-service=`cat ${CONF_FILE} | grep ^service | cut -d "=" -f 2`
-namespace=`cat ${CONF_FILE} | grep ^namespace | cut -d "=" -f 2`
+service=$SERVICE
Review comment:
please add a check here in case environment variables are missing here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
