pbacsko commented on a change in pull request #48: URL: https://github.com/apache/incubator-yunikorn-release/pull/48#discussion_r733655365
########## File path: helm-charts/yunikorn/templates/deployment.yaml ########## @@ -93,6 +93,12 @@ spec: exec: command: ["/bin/sh", "/admission_util.sh", "create"] {{ end }} + livenessProbe: Review comment: Think about `failureThreshold`. Looking at the upstream docs, that's 3 by default. Now, if YK fails, then it's only considered failed after 1800 seconds (30 mins). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org