-1 based on the helm chart issues:
* unknown files in the helm chart (publickey and yaml files)
* helm README content is not correct

I was able to:
* check signature
* check hash
* build from source
* startup and run the tests
* manually deployed image

On Wed, 15 Dec 2021 at 10:34, Craig Condit <apa...@craigcondit.com> wrote:

> Seeing a few issues with the archive:
>
> 1) there’s a stale public.key file in the helm-charts dir, which should
> probably not be in the archive.
> 2) The helm charts that are present don’t seem to correspond with any
> known version I can see. The differ significantly with both master and
> branch-0.12.1 upstream.
> 3) helm-charts/yunikorn/README.md seems to be missing the updated K8s
> versions (probably a missing commit somewhere).
>
>
> Craig
>
> > On Dec 14, 2021, at 4:05 PM, Craig Condit <apa...@craigcondit.com>
> wrote:
> >
> > Was able to verify this time. However, I think the archive needs to be
> regenerated as the helm chart key is still the old one (not @apache.org).
> >
> >
> >> On Dec 14, 2021, at 3:40 PM, Chaoran Yu <yuchaoran2...@gmail.com>
> wrote:
> >>
> >> Thanks Craig for catching that! I’ve re-signed all the release
> artifacts using the key corresponding to my Apache email. New artifacts
> have been uploaded to the same location. My key has been uploaded to the
> MIT key server as well.
> >>
> >>
> >>> On Dec 14, 2021, at 12:45, Craig Condit <apa...@craigcondit.com
> <mailto:apa...@craigcondit.com>> wrote:
> >>>
> >>> Hi Chaoran,
> >>>
> >>> Thanks for putting all this together.
> >>>
> >>> I’m trying to verify the release, but am running into some issues with
> the signing key. Did you upload it to pgpkeys.mit.edu <
> http://pgpkeys.mit.edu/><http://pgpkeys.mit.edu/ <http://pgpkeys.mit.edu/>>?
> Also, it seems that it is not an @apache.org address. AFAIK, that is
> required?
> >>>
> >>>
> >>> Thanks,
> >>>
> >>> Craig
> >>>
> >>>
> >>>> On Dec 14, 2021, at 1:58 PM, Chaoran Yu <yuchaoran2...@gmail.com>
> wrote:
> >>>>
> >>>> My public key is at
> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS <
> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS>. Sorry
> about the wrong link
> >>>>
> >>>>
> >>>>> On Dec 14, 2021, at 11:46, Chaoran Yu <yuchaoran2...@gmail.com>
> wrote:
> >>>>>
> >>>>> Hi all,
> >>>>>
> >>>>> I'd like to call a vote for a release candidate for Apache YuniKorn
> (incubating) 0.12.1 release.
> >>>>>
> >>>>> The release artifacts have been uploaded to
> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.12.1/ <
> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.12.1/>
> >>>>>
> >>>>> My public key is located here
> https://dist.apache.org/repos/dist/release/incubator/yunikorn/KEYS <
> https://dist.apache.org/repos/dist/release/incubator/yunikorn/KEYS>
> >>>>>
> >>>>> The release has been tagged with "v0.12.1" in all our git
> repositories.
> >>>>>
> >>>>> The JIRA issues that have been resolved in this release can be found
> here <https://issues.apache.org/jira/projects/YUNIKORN/versions/12350843>.
> >>>>>
> >>>>> Please review and vote. The vote will be open for at least 72 hours
> and
> >>>>> closes on Friday, December 17 2021, 1pm PDT.
> >>>>>
> >>>>> [ ] +1 approve
> >>>>> [ ] +0 no opinion
> >>>>> [ ] -1 disapprove (and the reason why)
> >>>>>
> >>>>>
> >>>>> Thank you,
> >>>>> Chaoran
> >>>>>
> >>>>
> >>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org <mailto:
> dev-unsubscr...@yunikorn.apache.org>
> >> For additional commands, e-mail: dev-h...@yunikorn.apache.org <mailto:
> dev-h...@yunikorn.apache.org>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
> For additional commands, e-mail: dev-h...@yunikorn.apache.org
>
>

Reply via email to