Michael Akinyemi created YUNIKORN-2126: ------------------------------------------
Summary: Fixing gocritic lint issues Key: YUNIKORN-2126 URL: https://issues.apache.org/jira/browse/YUNIKORN-2126 Project: Apache YuniKorn Issue Type: Improvement Components: core - scheduler Reporter: Michael Akinyemi Run {{./tools/golangci-lint run in the core}} {{Searching for "gocritic" warnings:}} {{}} cmd/schedulerclient/client.go:72:3: commentFormatting: put a space between `//` and comment text (gocritic) //if err := stream.CloseSend(); err != nil { ^ cmd/schedulerclient/client.go:50:3: exitAfterDefer: log.Fatalf will exit, and `defer cancel()` will not run (gocritic) log.Fatalf("could not greet: %v", err) ^ pkg/scheduler/placement/rule.go:124:9: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(name, configs.DOT, configs.DotReplace, -1)` (gocritic) return strings.Replace(name, configs.DOT, configs.DotReplace, -1) ^ -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org