Chia-Ping Tsai created YUNIKORN-2551:
----------------------------------------
Summary: Move `buildRules` out of `AppPlacementManager` to be a
function
Key: YUNIKORN-2551
URL: https://issues.apache.org/jira/browse/YUNIKORN-2551
Project: Apache YuniKorn
Issue Type: Improvement
Reporter: Chia-Ping Tsai
Assignee: Chia-Ping Tsai
https://github.com/apache/yunikorn-core/blob/master/pkg/scheduler/placement/placement.go#L70
{code:java}
func (m *AppPlacementManager) initialise(rules []configs.PlacementRule) error {
log.Log(log.Config).Info("Building new rule list for placement manager")
// build temp list from new config
// here!!!
tempRules, err := m.buildRules(rules)
if err != nil {
return err
}
m.Lock()
defer m.Unlock()
{code}
We call `m.buildRules` without holding AppPlacementManager lock since
`buildRules` does not touch any fields of `AppPlacementManager`. It seems to me
we should make `buildRules` be a function rather than method of
`AppPlacementManager`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
