This issue could also be faced by non-autoscaled clusters who still gets a node added at some point. Right?
-Mit From: Peter Bacsko <bacs...@gmail.com> Date: Thursday, May 16, 2024 at 11:23 AM To: dev@yunikorn.apache.org <dev@yunikorn.apache.org> Subject: Re: [VOTE] Release Apache YuniKorn 1.5.1 RC1 I'm fine with either approach. If it's too late, then let's go ahead with 1.5.1. Maybe it's better this way because we can do a more thorough verification. Peter On Thu, May 16, 2024 at 8:15 PM Craig Condit <ccon...@apache.org> wrote: > IMO, it’s too late to update 1.5.1. We’ve already cut the tags, and those > must remain immutable. Our best bet would probably be to continue with > 1.5.1 as-is; the new issue is unlikely to affect non-autoscaled clusters > and it’s better than 1.5.0. We should, I think, get this latest issue fixed > and go for 1.5.2. > > Do we have a fix yet? If so, we could probably push for 1.5.2 alone. But > either way, 1.5.1 is already baked. > > > Craig > > > > On May 16, 2024, at 1:06 PM, Peter Bacsko <bacs...@gmail.com> wrote: > > > > Dear community, > > > > I've been working together with Jacob Salway on an issue and we found out > > that there's one more deadlock in the shim which can be triggered when a > > new node is added. This means that an autoscaler setup is prone to a > > deadlock. > > > > I filed a JIRA which explains the problem: > > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FYUNIKORN-2629&data=05%7C02%7Cmdesai%40visa.com%7Cdcae530e12744b3b959d08dc75d549a6%7C38305e12e15d4ee888b9c4db1c477d76%7C0%7C0%7C638514806143403455%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=hsPVxgphiw1b6zTFScOiQ%2Fea7%2BydOqLpZCdqp38V26s%3D&reserved=0<https://issues.apache.org/jira/browse/YUNIKORN-2629> > > > > I already published the release artifacts to the release repo, GitHub and > > dockerhub, however no announcement has been made. I think we need an RC2 > > and re-run the voting and delete the artifacts. > > > > Thoughts, opinions? > > > > Peter > > > > On Thu, May 16, 2024 at 11:34 AM Peter Bacsko <bacs...@gmail.com> wrote: > > > >> +1 binding > >> > >> - Built images from source (amd64) on Ubuntu 22.04 > >> - Run make test && make image > >> - Run it on a local cluster > >> - Checked some REST API endpoints > >> - Ran sample jobs > >> > >> Thank you all for the voting on the RC1 for 1.5.1. > >> > >> Voting for the release has passed with: > >> 5 binding +1 > >> 3 non binding +1 > >> > >> no 0 or -1 votes. > >> > >> As the next step, I'll publish the release, images and update the > website. > >> After that is done I will send an announcement email. > >> > >> Thank you, > >> Peter > >> > >> > >> On Wed, May 15, 2024 at 4:45 PM Manikandan R <maniraj...@gmail.com> > wrote: > >> > >>> +1 (Binding) > >>> > >>> - Built images from source on Mac M1 MacOS Monterey (arm64) with go > 1.21.8 > >>> - Verified the signatures > >>> - Verified the licences and checksums > >>> - Run the scheduler with a local kind cluster (version 1.29.0) > >>> - Ran simple sleep jobs > >>> - Verified REST APIs outputs, Web UI > >>> > >>> Thanks, > >>> Mani > >>> > >>> On Tue, May 14, 2024 at 9:41 PM Desai, Mit <mde...@visa.com.invalid> > >>> wrote: > >>> > >>>> +1 (non-binding) > >>>> > >>>> > >>>> * Built release on MacOS Sonoma (arm64) > >>>> * Installed locally on Kind Cluster (1.28) > >>>> * Successfully ran make test > >>>> * Ran sample sleep jobs > >>>> > >>>> Thank you, Peter, for your efforts in driving the release. > >>>> > >>>> - Mit Desai > >>>> > >>>> From: Peter Bacsko <bacs...@gmail.com> > >>>> Date: Friday, May 10, 2024 at 1:41 AM > >>>> To: dev@yunikorn.apache.org <dev@yunikorn.apache.org> > >>>> Subject: [VOTE] Release Apache YuniKorn 1.5.1 RC1 > >>>> Hello everyone, > >>>> > >>>> I would like to call a vote for releasing Apache YuniKorn 1.5.1 RC1. > >>>> This is a minor release which contains only bugfixes. > >>>> > >>>> The release artefacts have been uploaded here: > >>>> > >>>> > >>> > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fyunikorn%2F1.5.1-RC1%2F&data=05%7C02%7Cmdesai%40visa.com%7Cdcae530e12744b3b959d08dc75d549a6%7C38305e12e15d4ee888b9c4db1c477d76%7C0%7C0%7C638514806143415049%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=wJ%2FIMOPtTVnE2assTlZVTb7PHUIpU5Qqe5nrHc0iz5w%3D&reserved=0<https://dist.apache.org/repos/dist/dev/yunikorn/1.5.1-RC1/> > >>>> <https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fyunikorn%2F1.5.1-RC1%2F&data=05%7C02%7Cmdesai%40visa.com%7Cdcae530e12744b3b959d08dc75d549a6%7C38305e12e15d4ee888b9c4db1c477d76%7C0%7C0%7C638514806143420650%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=c3nhf0zXsDDNz1sLEQCf%2BboVxMN6zeaFfIjxrasQsX8%3D&reserved=0<https://dist.apache.org/repos/dist/dev/yunikorn/1.5.1-RC1/>> > >>>> > >>>> My public key is located in the KEYS file: > >>>> > >>>> > >>> > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdownloads.apache.org%2F%2Fyunikorn%2FKEYS&data=05%7C02%7Cmdesai%40visa.com%7Cdcae530e12744b3b959d08dc75d549a6%7C38305e12e15d4ee888b9c4db1c477d76%7C0%7C0%7C638514806143424965%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=XxGJus0HmN7wPQZWFDIcgxpyLgSJwj%2FP3LG%2BdSW%2FFS8%3D&reserved=0<https://downloads.apache.org//yunikorn/KEYS> > >>>> <https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdownloads.apache.org%2F%2Fyunikorn%2FKEYS&data=05%7C02%7Cmdesai%40visa.com%7Cdcae530e12744b3b959d08dc75d549a6%7C38305e12e15d4ee888b9c4db1c477d76%7C0%7C0%7C638514806143429166%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=SY8V3baS6K8n08CNZc55Y4mWASchOYc7eKa%2BAx4QvjY%3D&reserved=0<https://downloads.apache.org//yunikorn/KEYS>> > >>>> > >>>> JIRA issues that have been resolved in this release: > >>>> > >>>> > >>> > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fissues%2F%3Ffilter%3D12353383&data=05%7C02%7Cmdesai%40visa.com%7Cdcae530e12744b3b959d08dc75d549a6%7C38305e12e15d4ee888b9c4db1c477d76%7C0%7C0%7C638514806143433039%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=rw4f%2FY2EVqB9sWj5I4jE2keAMQTNMzOiWymmKPw6%2BXs%3D&reserved=0<https://issues.apache.org/jira/issues/?filter=12353383> > >>>> <https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fissues%2F%3Ffilter%3D12353383&data=05%7C02%7Cmdesai%40visa.com%7Cdcae530e12744b3b959d08dc75d549a6%7C38305e12e15d4ee888b9c4db1c477d76%7C0%7C0%7C638514806143437032%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=zmGogCkdDTNhxmKZKxTvGf9vlERXdeqPUACvAp%2BM8%2BM%3D&reserved=0<https://issues.apache.org/jira/issues/?filter=12353383>> > >>>> > >>>> The release solves a deadlock issue. If possible, test Yunikorn with > >>>> workloads that put Yunikorn under stress (ie. thousands/tens of > >>> thousands > >>>> of pods). > >>>> > >>>> Git tags for each component are as follows: > >>>> yunikorn-scheduler-interface: v1.5.1-1 > >>>> yunikorn-core: v1.5.1-1 > >>>> yunikorn-k8shim: v1.5.1-1 > >>>> yunikorn-web: v1.5.1-1 > >>>> yunikorn-release: v1.5.1-1 > >>>> > >>>> Once the release is voted on and approved, all repos will be tagged > >>>> 1.5.1 for consistency. > >>>> > >>>> Please review and vote. The vote will be open for at least 96 hours > >>>> and closes on Tuesday 14 May 2024, 20:00:00 CEST. > >>>> > >>>> [ ] +1 Approve > >>>> [ ] +0 No opinion > >>>> [ ] -1 Disapprove (and the reason why) > >>>> > >>>> > >>>> Thank you, > >>>> Peter > >>>> > >>> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org > For additional commands, e-mail: dev-h...@yunikorn.apache.org > >