[ https://issues.apache.org/jira/browse/YUNIKORN-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Condit resolved YUNIKORN-2760. ------------------------------------ Fix Version/s: 1.6.0 Target Version: 1.6.0 Resolution: Fixed Merged to master. Thanks [~blue.tzuhua] for the contribution! > `make tools` should check the version of tools > ---------------------------------------------- > > Key: YUNIKORN-2760 > URL: https://issues.apache.org/jira/browse/YUNIKORN-2760 > Project: Apache YuniKorn > Issue Type: Improvement > Reporter: Chia-Ping Tsai > Assignee: Tzu-Hua Lan > Priority: Major > Labels: pull-request-available > Fix For: 1.6.0 > > > Makefile, by default, checks only the existence of file. Hence, developers > need to remove tools folder (or call `make distclean`) manually to trigger > the installation after we update the version of tools. > However, how developers can be aware of the tools updates? Personally, I > smell fishy from the error of warning, but that could be implicit and noisy > :cry > In order to fix that, I'd like to introduce the new folder structure to tools > folder: > {code:java} > /tools/{tool_name}-{version} > {code} > That offers a unique path to each version of tool. Developers will not miss > the updates anymore. > *rejected proposal* > {code:java} > /tools/{tool_name}/{version} > {code} > That offers a unique path to each version of tool. Developers will not miss > the updates anymore. > NOTED: we need to remove the existent tool binary if there is naming conflict > in creating the new path. For example, creating /tools/golangci-lint/1.57.2 > will fail if /tools/golangci-lint is a existent file. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org