Issue #271 has been updated by Philipp Buluschek.
In r1087 : the check for negative network address should not be done in the constructor, but rather in the @setNetworkAddress@ method - else somebody might set a new negative value later. Also, it is not recommended to call overridable methods in the constructor (see eg. http://stackoverflow.com/questions/3404301). Easiest fix: make the class final. ---------------------------------------- Improvement #271: Avoid to set Network Address to negative number http://zb4o.aaloa.org/redmine/issues/271#change-697 Author: Stefano Lenzi Status: Resolved Priority: Immediate Assignee: Stefano Lenzi Category: zigbee.basedriver Target version: org.aaloa.zb4osgi.zigbee.basedriver-0.8.0 Has a patch: No Has license agreement signed: No Since #264 was proposed we should also avoid that negative valus is stored as network address is the ZigBeeNode interface -- DO NOT ANSWER TO THIS E-MAIL ADDRESS, NO ONE WILL READ IT. PLEASE WRITE TO [email protected] ZigBee 4 OSGi - Redmine E-Mail Notificatioon You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://zb4o.aaloa.org/redmine
_______________________________________________ Dev mailing list [email protected] http://zb4osgi.aaloa.org/mailman/listinfo/dev
