GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/956

    [ZEPPELIN-923] Apply new mechanism to ShellInterpreter

    ### What is this PR for?
    This PR applies the new interpreter registration mechanism to Shell 
interpreter.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [x] - Remove static property definition code lines in 
`shellInterpreter.java` and add `interpreter-setting.json` under the 
`shell/src/main/resources`
    
    ### What is the Jira issue?
    [ZEPPELIN-923](https://issues.apache.org/jira/browse/ZEPPELIN-923)
    
    ### How should this be tested?
    1. apply patch
    2. rm -r `interpreter/sh` and `conf/interpreter.json`
    3. build source 
    4. bin/zeppelin-daemon.sh start
    5. Run some shell command
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-923

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/956.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #956
    
----
commit e312f5a88a7c5b082a37f56215ea92df469f4403
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2016-06-03T16:16:20Z

    ZEPPELIN-923: Apply new interpreter mechanism to Shell interpreter

commit f6a693356b34d1ff101dff779dafe135920def1a
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2016-06-03T16:18:51Z

    ZEPPELIN-923: Change defaultValue 5000 -> 60000

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to