GitHub user astroshim opened a pull request:

    https://github.com/apache/zeppelin/pull/1064

    BugFix-blocking of blank values insertion on the Credential page.

    ### What is this PR for?
    This PR blocks the blank values insertion on the Credential page and 
    changes the success message box to zeppelin's dialog box.
    
    
    ### What type of PR is it?
    Bug Fix
    
    
    ### How should this be tested?
    Try to save with blank values on the Credential page.
    
    ### Screenshots (if appropriate)
      - before 
    
![out](https://cloud.githubusercontent.com/assets/3348133/16255783/c5d19378-3887-11e6-9eec-5fcac42ee276.gif)
    
    
      - after
    
![image](https://cloud.githubusercontent.com/assets/3348133/16255706/18967912-3887-11e6-8823-21683c17082d.png)
    
    
    
![image](https://cloud.githubusercontent.com/assets/3348133/16255722/55c9f494-3887-11e6-84f8-857a7f5380d6.png)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/astroshim/zeppelin feat/checkCredentialValues

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1064.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1064
    
----
commit e148d44e10850c8bab4f0d9c7e3b97b1e48cf7a0
Author: astroshim <hss...@nflabs.com>
Date:   2016-06-22T05:04:26Z

    disallow the blank values of Credential on the front.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to