GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1100
[ZEPPELIN-1054] Improve "Credentials" UI
### What is this PR for?
Currently, users can add new their credential info for data source
authentication in Zeppelin "Credentials" menu. Even though it was saved
successfully, they can't see the whole list of credentials in Zeppelin UI.
This PR enables to `get` all credential list, `edit` and `remove` via UI.
*NOTE : Since this patch was implemented based on #1030 API, should be
tested after #1030 merged.*
### What type of PR is it?
Improvement & Documentation
### Todos
* [x] - rename `interpreter_authorization.md` ->
`datasource_authorization.md`
* [x] - remove `Interpreter Authorization` section (since we don't have
this feature yet :
[ZEPPELIN-945](https://issues.apache.org/jira/browse/ZEPPELIN-945))
* [ ] - rebase after #1030 & #1064 merged
### What is the Jira issue?
[ZEPPELIN-1054](https://issues.apache.org/jira/browse/ZEPPELIN-1054)
### How should this be tested?
1. Apply this patch and build `zeppelin-web` as described in
[here](https://github.com/apache/zeppelin/tree/master/zeppelin-web#configured-environment).
2. Go to `Credentials` menu.
3. Add new credentials -> you can see the credential info in the credential
list table.
4. You can edit & delete them. -> Compare with `conf/credentials.json`
### Screenshots (if appropriate)
- Before
<img width="952" alt="screen shot 2016-06-28 at 12 37 10 am"
src="https://cloud.githubusercontent.com/assets/10060731/16407604/69b0c4d8-3cc9-11e6-8284-9abe2969cdc1.png">
- After

If there is no credential
<img width="957" alt="screen shot 2016-06-28 at 12 19 46 am"
src="https://cloud.githubusercontent.com/assets/10060731/16407620/7838995e-3cc9-11e6-90ba-1bd0173a1b49.png">
- `datasource_authorization.md`
<img width="836" alt="1"
src="https://cloud.githubusercontent.com/assets/10060731/16407680/d176ddf0-3cc9-11e6-9070-178400ad7c86.png">
<img width="829" alt="2"
src="https://cloud.githubusercontent.com/assets/10060731/16407681/d4168d8a-3cc9-11e6-9319-018ae440cef8.png">
<img width="842" alt="3"
src="https://cloud.githubusercontent.com/assets/10060731/16407682/d5f36a10-3cc9-11e6-8b9a-13b09960cda6.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1054
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1100
----
commit 3681e96d84e8fe9094c3149685e61b51e914eab0
Author: AhyoungRyu <[email protected]>
Date: 2016-06-27T17:35:02Z
Enable credential info to get list, edit and remove via UI
commit 50ea0ac2549b70bdd96bd292bc3be63a0f5b7060
Author: AhyoungRyu <[email protected]>
Date: 2016-06-27T17:35:25Z
Update angular-xeditable version
commit 00cc690b1a2fc17c35b7c76d703c8f9f500450b5
Author: AhyoungRyu <[email protected]>
Date: 2016-06-27T17:34:11Z
Add datasource_authorization.md to index & navi menu
commit 071f18f82b71719b2e88aafbe77734d17ec02701
Author: AhyoungRyu <[email protected]>
Date: 2016-06-28T07:14:33Z
Add datasource_authorization.md docs
commit f7c6a7d1832f3d7516e3388b2fdbe5e6a81bcc9c
Author: AhyoungRyu <[email protected]>
Date: 2016-06-28T07:56:33Z
Fix indentation
commit 32e5809a9d7c80cfcd83a6b2501f8dc50dbbf537
Author: AhyoungRyu <[email protected]>
Date: 2016-06-28T08:03:55Z
Delete interpreter_authorization.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---