GitHub user jongyoul reopened a pull request:

    https://github.com/apache/zeppelin/pull/1102

    [ZEPPELIN-1075] Merge NoteInterpreterLoader into InterpreterFactory

    ### What is this PR for?
    Removing redundant codes between `NoteInterpreterLoader` and 
`InterpreterFactory`, reducing the cost to add new features, and making 
refactoring on `InterpreterFactory` easy
    
    ### What type of PR is it?
    [Refactoring]
    
    ### Todos
    * [x] - Remove `NoteInterpreterLoader` and move the functionality into 
`InterpreterFactory`
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1075
    
    ### How should this be tested?
    Must pass all tests
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1075

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1102
    
----
commit 9c3c82db5f2599cd1fbd9ef3faa8abf71fd349ac
Author: Jongyoul Lee <jongy...@gmail.com>
Date:   2016-06-28T16:37:22Z

    Duplicated all method in NoteInterpreterLoader to InterpreterFactory

commit a2115d37ab37064f3469a37f8a12c1beb273707d
Author: Jongyoul Lee <jongy...@gmail.com>
Date:   2016-06-28T17:00:36Z

    Removed NoteInterpreterLoader
    Fixed some tests

commit 9a13a752fae16a8ace6f47ad64a0edb9b627a1e6
Author: Jongyoul Lee <jongy...@gmail.com>
Date:   2016-06-29T01:20:09Z

    Fixed style

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to