GitHub user cloverhearts reopened a pull request:

    https://github.com/apache/zeppelin/pull/1125

    ZEPPELIN-1107 ] Doesn't work autocompletion for jdbc interpreter

    ### What is this PR for?
    Doesn't work autocompletion for jdbc interpreter
    'Completion' There is a problem with the return type of implementation.
    
    ```
    org.apache.zeppelin.interpreter.InterpreterException: 
org.apache.thrift.transport.TTransportException
        at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.completion(RemoteInterpreter.java:396)
        at 
org.apache.zeppelin.interpreter.LazyOpenInterpreter.completion(LazyOpenInterpreter.java:122)
        at org.apache.zeppelin.notebook.Paragraph.completion(Paragraph.java:216)
        at org.apache.zeppelin.notebook.Note.completion(Note.java:488)
        at 
org.apache.zeppelin.socket.NotebookServer.completion(NotebookServer.java:729)
        at 
org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:202)
        at 
org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:56)
        at 
org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128)
        at 
org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
        at 
org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65)
        at 
org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122)
        at 
org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161)
        at 
org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309)
        at 
org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
        at 
org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
        at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
        at 
org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632)
        at 
org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480)
        at 
org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
        at 
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
        at 
org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
        at java.lang.Thread.run(Thread.java:745)
    Caused by: org.apache.thrift.transport.TTransportException
        at 
org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:132)
        at org.apache.thrift.transport.TTransport.readAll(TTransport.java:86)
        at 
org.apache.thrift.protocol.TBinaryProtocol.readAll(TBinaryProtocol.java:429)
        at 
org.apache.thrift.protocol.TBinaryProtocol.readI32(TBinaryProtocol.java:318)
        at 
org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.java:219)
        at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:69)
        at 
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Client.recv_completion(RemoteInterpreterService.java:346)
        at 
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Client.completion(RemoteInterpreterService.java:330)
        at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.completion(RemoteInterpreter.java:392)
    
    ```
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1107
    
    ### How should this be tested?
    try to completion for jdbc interpreter paragraph.
    
    ### Screenshots (if appropriate)
    
![jdbc](https://cloud.githubusercontent.com/assets/10525473/16565048/c9a74124-4245-11e6-8b6f-b78c3a038e9e.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin bugfix/jdbc-completion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1125
    
----
commit 498975ede2d63ad50a2b84130d293a2c55733a09
Author: CloverHearts <cloverheartsdev+git...@gmail.com>
Date:   2016-07-04T15:03:09Z

    bug fixed autocompletion for jdbc interpreter

commit 98c1cefe6dba673022ad9c238dcec8468535e38a
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2016-07-06T06:28:38Z

    Added JDBC Interpreter completion test case.

commit dfa4769f2e5e9536fd712b9c522cad3a524ae236
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2016-07-06T07:38:19Z

    JDBC Completion test case - fixed size

commit fc9bf5551a386e8eff1acd416a1d53adddd216ca
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2016-07-06T07:42:24Z

    print test case result value.

commit ed41332244156d8fe32c355a5f5c5664c037701a
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2016-07-06T07:50:52Z

    fixed testcase for JDBC Interpreter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to