[GitHub] zeppelin pull request #1148: [ZEPPELIN-1026] set syntax highlight based on d...

[minahlee]

GitHub user minahlee opened a pull request:

    https://github.com/apache/zeppelin/pull/1148

    [ZEPPELIN-1026] set syntax highlight based on default bound interpreter

    ### What is this PR for?
    - Set syntax highlight based on default interpreter if %magic is not set
    - Get syntax highlight mode from backend
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] Add test
    * [ ] Update 
[writingzeppelininterpreter.md](https://github.com/apache/zeppelin/blob/master/docs/development/writingzeppelininterpreter.md)
    * [ ] Rebase after #1145 merged
    
    ### What is the Jira issue?
    [ZEPPELIN-1026](https://issues.apache.org/jira/browse/ZEPPELIN-1026)
    
    ### Screenshots (if appropriate)
    **Before**
    <img width="665" alt="screen shot 2016-07-07 at 10 46 20 pm" 
src="https://cloud.githubusercontent.com/assets/8503346/16655312/af67a302-4494-11e6-949e-793ad0515d7a.png";>
    
    
    **After**
    <img width="666" alt="screen shot 2016-07-07 at 10 44 39 pm" 
src="https://cloud.githubusercontent.com/assets/8503346/16655248/769d8ba4-4494-11e6-9b3c-dc5e026e9c53.png";>
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? yes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1026

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1148.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1148
    
----
commit ecb0af22df5e31641d87fdbf729c14186c0a56af
Author: Mina Lee <mina...@apache.org>
Date:   2016-07-07T10:12:28Z

    Add editor field

commit 32ed3637eedb4ab5ca93f4049bd3c711f0d5634b
Author: Mina Lee <mina...@apache.org>
Date:   2016-07-07T11:42:53Z

    Align comments for readability

commit 466e6a860af78e385304d17671edc5ab75d98aeb
Author: Mina Lee <mina...@apache.org>
Date:   2016-07-07T12:17:12Z

    Get paragraph editor mode from backend

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---