GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/1179

    [ZEPPELIN-1109] Remove bootstrap dialog fade-in/out animation

    ### What is this PR for?
    This PR will fix 
[ZEPPELIN-1109](https://issues.apache.org/jira/browse/ZEPPELIN-1109). 
    I'm not sure this approach can be the best way for fixing this issue. So if 
anyone has better idea, please let me know. 
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-1109](https://issues.apache.org/jira/browse/ZEPPELIN-1109)
    
    ### How should this be tested?
    1. Press `Enter` button right after clicking any bootstrap dialog (i.e. 
trash can icon in the notebook) 
    -> Bootstrap dialog will be shown up multiple times
    2. Apply this patch and [build 
`zeppelin-web`](https://github.com/apache/zeppelin/tree/master/zeppelin-web#configured-environment)
    3. Try number 1 again -> you can see there is no fade animation so you 
don't have time interval to generate multi dialogs
    
    ### Screenshots (if appropriate)
     - Before 
    
![multiple_dialog](https://cloud.githubusercontent.com/assets/10060731/16799515/25973fb0-492c-11e6-981e-19d46db31520.gif)
    
     - After
    
![remove_animation](https://cloud.githubusercontent.com/assets/10060731/16799517/2980f6d4-492c-11e6-8a5a-905800665e9f.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1109

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1179
    
----
commit 77c94eeaca732fed4410cf9a39ba4c86a7b6eb37
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2016-07-13T09:53:59Z

    Remove bootstrap dialog animation by default

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to