GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1204
[Zeppelin-1089] Replace JsHint with Eslint
### What is this PR for?
This PR replace JsHint with Eslint, the original configuration was ported
from jsHint using [Polyjuice](https://www.npmjs.com/package/polyjuice), then
the settings were tuned to match exactly.
For this PR, the goal is not to add new rules, but only to replace the
system with the same rules.
### What type of PR is it?
Improvement
### Todos
* [x] - Remove .jshintrc
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1089
### How should this be tested?
You can simply build the code.
You can try to add an unused variable in the js code to see an error.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1089
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1204
----
commit 7b1da053cc8feb302ede04e95b6bdd10fc6933ea
Author: Damien CORNEAU <[email protected]>
Date: 2016-07-19T09:40:00Z
Replace JsHint by Eslint
commit 0364ad48d03770603a2a952a1077e717cba107f7
Author: Damien CORNEAU <[email protected]>
Date: 2016-07-19T10:00:43Z
Fix eslint for tests
commit e1b389fa8e79b7ba7cd992955e8337c7bab23610
Author: Damien CORNEAU <[email protected]>
Date: 2016-07-19T23:48:58Z
remove .jsintrc
commit e71389d3f0b42ba1df5d3594d04487b7dee8185c
Author: Damien CORNEAU <[email protected]>
Date: 2016-07-19T23:55:08Z
remove jshint remnants
commit 6cf1e2a71310c228e7d04b2899be52f2eb613f26
Author: Damien CORNEAU <[email protected]>
Date: 2016-07-20T06:00:12Z
fix $ is missing error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
