[GitHub] zeppelin pull request #1160: [Zeppelin - 1152] Listing note revision history

Wed, 20 Jul 2016 20:06:55 -0700 

GitHub user khalidhuseynov reopened a pull request:

    https://github.com/apache/zeppelin/pull/1160

    [Zeppelin - 1152] Listing note revision history

    ### What is this PR for?
    This PR addresses ability to view the history of note revisions from the 
`version control` menu
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [x] - backend changes
    * [x] - tests
    * [x] - propagation to frontend
    * [x] -  rendering list
    
    ### What is the Jira issue?
    [Zeppelin - 1152](https://issues.apache.org/jira/browse/ZEPPELIN-1152)
    
    ### How should this be tested?
    1. Select Git notebook storage layer as primary (e.g. in 
`conf/zeppelin-env.sh` add 
    ``` 
    export 
ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
    ```
    2. Select any note in Zeppelin and `commit` it in `version control` menu
    3. The list with new commit should be shown in the same menu
    
    ### Screenshots (if appropriate)
    <img width="782" alt="screen shot 2016-07-21 at 11 35 21 am" 
src="https://cloud.githubusercontent.com/assets/1642088/17009639/c8bcbd58-4f37-11e6-92cd-88147b7419e6.png";>
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
front/list-revision-history

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1160
    
----
commit a7e8fd8ee07cc61ad744acebdc9166d5cbaabe27
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-04T07:57:07Z

    initial impl

commit d8f42828bb2c55eb6fa51586c6e044eb1b88bba1
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-10T04:49:28Z

    add new note resource for tests with multiple notes

commit b4c69dfab3ab1b00295551502df79cc3ed6ef2c3
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-10T05:43:53Z

    add test: revision history, multiple notes

commit 18d430a2cc3124f0951fa923ccd24d6f4cbf3499
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-11T06:26:49Z

    add initial listing

commit bcf6cf1d3bdeee628d634924cf44bcb87f8b3183
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-11T07:15:24Z

    return list on successful commit

commit 660139b91e7416ffd975e6bb58914664e7d97a2c
Author: Damien CORNEAU <[email protected]>
Date:   2016-07-12T06:03:25Z

    fix the jscs error

commit 9523b481a1254ab9fbb51834f5e61660a7528eab
Author: Damien CORNEAU <[email protected]>
Date:   2016-07-12T08:48:43Z

    Add dropdown of revisions

commit ee7b94fc501f939dc09b5fd2e595add8e466e4ee
Author: Damien CORNEAU <[email protected]>
Date:   2016-07-12T08:53:16Z

    Reverse revisions order to have the latest first

commit 1d20aeb7f573cf3fadeb6be0a28a8ca37a7d8f21
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-13T09:00:45Z

    fix jshint checkstyle

commit 2090d60bd36d38477e8cb2b59917d2c9a3ed08f7
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-14T04:19:44Z

    mock listRevisionHistory

commit e6bafdec84cd4e5a42d07f04abc696941b6e81bd
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-18T18:06:22Z

    change time format

commit 4607c0309d9e3a37b33e648e8512155b870e6293
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-19T06:16:52Z

    fix css
    
    fix rebase

commit 0445b42de01acea8dccc0843de714de91926b5a2
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-19T13:26:40Z

    move date to right, add time

commit bd068fdf43a9177fd16bc7a3c23ee74aaab81212
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-19T13:35:42Z

    add css class with smaller font for revision date

commit f676b741c74d308157e7cf60ab3b1db59d215e95
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-20T03:51:22Z

    Merge branch 'master' into front/list-revision-history

commit 614ed61ab1b47bd5276d64d477983b605a25f6b8
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-20T08:26:10Z

    date: smaller font and spacing

commit 01343caecb1972bbf02b692ddcd6f1c151d2a247
Author: Khalid Huseynov <[email protected]>
Date:   2016-07-21T02:32:01Z

    address @corneadoug comments

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to