GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/1215

    ZEPPELIN-1225. Errors before the last shell command are ignored

    ### What is this PR for?
    The problem is that command "bash -c <shell scripts>" will always return 0 
as long as the last line of shell script run correctly. e.g the following 
command will run correctly without any error message.
    ```
    hello
    pwd
    ``` 
    This PR will redirect stderr and stdout to the same place, and will display 
both the stderr and stdout to frontend just like what user see in the native 
shell terminal. So the output of above command will be as following
    ```
    bash: hello: command not found
    /Users/jzhang/github/zeppelin
    ```
    
    ### What type of PR is it?
    [Bug Fix]
    
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1225
    
    ### How should this be tested?
    Unit test is added and also manually verify it on zeppelin notebook. 
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/incubator-zeppelin ZEPPELIN-1225

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1215
    
----
commit 0266c719c2481a30817b36a1508eab62f868263f
Author: Jeff Zhang <zjf...@apache.org>
Date:   2016-07-22T05:02:30Z

    ZEPPELIN-1225. Errors before the last shell command are ignored

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to