Github user onkarshedge commented on the issue:

    https://github.com/apache/zeppelin/pull/1231
  
    @khalidhuseynov  thanks for helping.
    
    To actually see `TorrentSocket` in action I have to create 
a`WebSocketCreator` and a `Servlet`, then add this to jetty server , [at this 
line](https://github.com/apache/zeppelin/blob/6f867ceb0c2b93ecca3be8a16c155547182eb0dc/zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java#L223)
    ```java
    webApp.addServlet(new ServletHolder("ws-events",new 
TorrentServlet()),"/download");
    ```
    So then should it be like this ...
    ```java
    public class BittorrentNotebookRepo extends VFSNotebookRepo implements 
TorrentEngineListener,
        WebSocketCreator {
    @Override
    public Object createWebSocket(ServletUpgradeRequest servletUpgradeRequest,
                     ServletUpgradeResponse servletUpgradeResponse) {
        return new TorrentSocket(this);
      }
    }
    ```
    And the `TorrentServlet` class
    ```java
    public class TorrentServlet extends WebSocketServlet {
      @Override
      public void configure(WebSocketServletFactory webSocketServletFactory) {
        webSocketServletFactory.setCreator(new BittorrentNotebookRepo());
      }
    }
    ```
    Here is the problem as I cannot instantiate the BittorrentNotebookRepo here 
, it requires `conf` parameter. Also the NotebookRepos' are instantiated in 
`NotebookRepoSync`. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to