GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1281
[ZEPPELIN-1290] Refactor Navbar Controller
### What is this PR for?
This is a small refactoring to keep this Controller following the
[ControllerAs with
vm](https://github.com/johnpapa/angular-styleguide/tree/master/a1#controlleras-with-vm)
rules, that it was based on.
Here is a list of things that were changed and why:
* Most of the controller's $scope values & fct (except from the search q)
where moved to the vm.The controller is using vm, so storing in $scope to share
with the view is not needed.
* Functions or Vars that are not used in the view were removed from the vm.
(kept private to the controller)
* $rootscope functions was moved to `app.js`. I think the need for that
function might need to be changed, but for the scope of this PR, we are just
moving it to where the $rootScope values are declared.
* Gathering vm declaration before the functions and ordered alphabetically
* Re-order functions alphabetically
* Create `initController ` to regroup all the controller setup.
### What type of PR is it?
Refactoring
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1290
### How should this be tested?
You can Just verify that the below Navbar related features are still good:
* Search Form
* Connected Status
* Login button
* User Name and its dropdown menu
* Notebook list drop-down menu (and filer, folder inside of it)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin
Refactor/navbarCtrl
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1281.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1281
----
commit 75a641e65eba4438f7ad19e7fa77d21c4b975b10
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-07-21T09:32:58Z
Remove functions from navbar controller
commit dd37f698208c42894dd895b5b38f3203816bc765
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-08-04T07:58:15Z
finish cleaning the controller
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
