GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1293
[ZEPPELIN- 1298] Log instead of throwing trace for ping messages
### What is this PR for?
When non authenticated user in non-anonymous mode tries to send any
websocket api message it results in throwing a traceback. However on PING
message we don't need to show the whole traceback and we can just log in order
not to pollute the logs file.
### What type of PR is it?
Hot Fix
### Todos
* [ ] - log and return on PING
### What is the Jira issue?
[Zeppelin-1298](https://issues.apache.org/jira/browse/ZEPPELIN-1298)
### How should this be tested?
Follow the steps in issue and shouldn't get repeating traceback.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
in anonymous not allowed mode normally any nonauthenticated websocket
message should throw an error, but ping doesn't do any job and no need to throw
on it probably, just return and log
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin
hotfix/zeppelin-1298
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1293.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1293
----
commit 4df77242e68f1a1830374763e6feb986100fba06
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-08-06T07:44:20Z
don't throw exception on ping
in anonymous not allowed mode normally any nonauthenticated websocket
message should throw an error, but ping doesn't do any job and no need to throw
on it probably, just return and log
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
