Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1304
@corneadoug thanks for clarification. in this case, how do you think it
would look like if `revisionId` cannot be represented as simple string and it's
more like complex object?
I believe @bzz had this point in the [comments
here](https://github.com/apache/zeppelin/pull/1254#issuecomment-236475181)
>Also, could you please explain why do you think this API change is
valuable and what benefits does it bring for a user? (i.e does it consider
other possible versioned storage i.e IPFS, BitTorrent and other future ones,
where just an ID might not be enough? or it might be not String)
and
[here](https://github.com/apache/zeppelin/pull/1254#issuecomment-236570441)
>Revision class implementation that you point out looks good to me - it
represents clearly defined interface with it's own responsibilities. But String
does the contrary. May be this class is even big enough to deserve his own
file. And other clients may choose to replace it with their own
implementations. I would understand if you suggest to extract it to the
interface - this will bring even more flexibility (but increase verbosity).
>But replacing it with the String does not look good to me.
So let's nail down this question here, and maybe together in the same
thread, we can come up with much better solution :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
