Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/989
  
    I'm a bit lost with this feature, is it really considered as a NotebookRepo 
or does it only keep the revisions? Does importing the Hash mean that it import 
a Revision as Notebook?
    
    Why do we need to comment the VFS while it still save in local file system?
    
    Also I think the ipfs installation steps shouldn't be in the NotebookRepo 
doc since not every user should be having a server running. It would be more 
fitting in this PR description on how to test this PR.
    
    #### Import form
    I would have classic URL by default, and the hash option only as a checkbox.
    
    #### Import Note event listener
    I left comments in the code



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to