Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1356
  
    I've tested and it looks nice.
    
    Some small feedback about sidemenu
    
    - When sidemenu is displayed, content area become little bit too narrow.
    - Items in Sidemenu is in consistent. i.e.
    
    page `/contribution/general.html`, sidemenu
      - Documentation (/contribution/documentation.html)
      - Webapplication (/contribution/webapplication.html)
    
    page `/contribution/webapplication.html`
      - Defining Components (/contribution/zeppelinweb/goodPracticeGuide01.html)
    
    page `/contribution/zeppelinweb/goodPracticeGuide01.html`
      - Defining Components (/contribution/zeppelinweb/goodPracticeGuide01.html)
    
    I think it'll better it sidemenu decide only one behavior either doesn't 
include current page, (like `general.html`,`webapplication.html`) or does 
include current page (like goodPracticeGuide01.html)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to