GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1469
[Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code
### What is this PR for?
This is some refactoring of zeppelin-web to apply the IIFE as stated in the
Good Practice Guide #1
(https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html)
### What type of PR is it?
Refactoring
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1496
### How should this be tested?
Run The webapp, and go around the page, things should work like usual.
But overall, just need to check that there is no type or parameter mismatch
during the refactoring process (controller to controller, params in $inject
etc...)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1496
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1469.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1469
----
commit b7b94b5ff3f87a535e3521f7551fd035e46744bf
Author: Damien CORNEAU <[email protected]>
Date: 2016-09-27T08:43:34Z
Add IIFE to app.controller.js
commit f179474f1482c8ca89f52511608c9c90db39efa0
Author: Damien CORNEAU <[email protected]>
Date: 2016-09-27T08:48:36Z
Move use strict outside IFFE
commit b946304b72395554165c95551d2b56784d431199
Author: Damien CORNEAU <[email protected]>
Date: 2016-09-27T08:59:03Z
Add congiguration.controller.js
commit bf4462c1f11a3994fa73022c976eccdab5e6a068
Author: Damien CORNEAU <[email protected]>
Date: 2016-09-28T05:36:38Z
Refactor for IIFE credential, home and interpreter controller
commit 66dd14debfb5a86d1906a7616b21c9c86c5fa4f2
Author: Damien CORNEAU <[email protected]>
Date: 2016-09-28T07:02:12Z
IIFE refactoring of job page
commit 56b2103bc8e902f5ec1c6b4bfa8070f4963ecbbd
Author: Damien CORNEAU <[email protected]>
Date: 2016-09-28T07:18:37Z
Finish refactoring of App
commit e7dcc2e9201bc9abfeb957c44b054ada085c72b6
Author: Damien CORNEAU <[email protected]>
Date: 2016-09-28T07:35:46Z
Refactor components service and factory
commit b45d0fa270dda72006297a0a4077b40a672d0cc0
Author: Damien CORNEAU <[email protected]>
Date: 2016-09-28T07:55:27Z
Refactor components directives
commit 3964e26663feee016ea0b50faa3e1c8c9490ea35
Author: Damien CORNEAU <[email protected]>
Date: 2016-09-28T08:56:28Z
refactor components controllers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
