GitHub user astroshim reopened a pull request:

    https://github.com/apache/zeppelin/pull/1433

    [ZEPPELIN-1451] Bug fix of Embedding %html within %table.

    ### What is this PR for?
    This PR fixes the bug of Embedding %html within %table.
    It doesn't print properly when the `%html` is the first line.
    
    ### What type of PR is it?
    Bug Fix
    
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1451
    
    
    ### How should this be tested?
    Run following code in your paragraph.
    ```
    print(s"""%table
    name\tsize\tquantity
    %html <img 
src='https://upload.wikimedia.org/wikipedia/commons/thumb/6/6f/Sun_symbol.svg/50px-Sun_symbol.svg.png'
 />sun\t100\t50
    %html <img 
src='https://upload.wikimedia.org/wikipedia/commons/thumb/2/2a/Moon_symbol_crescent.svg/25px-Moon_symbol_crescent.svg.png'
 />moon\t10\t20""")
    ```
    
    ### Screenshots (if appropriate)
    - before
    
![image](https://cloud.githubusercontent.com/assets/3348133/18616055/30262a38-7df0-11e6-8d9c-441f50df77c6.png)
    
    
    - after
    
![image](https://cloud.githubusercontent.com/assets/3348133/18616073/73ba51c0-7df0-11e6-8a91-b13074ec80e4.png)
    
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1451

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1433.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1433
    
----
commit f3d11a07a9e3ef405d2c7376f802c92a14ce6788
Author: astroshim <hss...@nflabs.com>
Date:   2016-09-18T13:26:13Z

    add checking the type should be detected.

commit 7724afdd0fa241a999a8023f05539f5c1e50c83b
Author: astroshim <hss...@nflabs.com>
Date:   2016-09-21T12:44:30Z

    Merge branch 'master' into ZEPPELIN-1451

commit a7a88e6e88a88d95e130d02d12310b234ad89787
Author: astroshim <hss...@nflabs.com>
Date:   2016-09-29T07:41:35Z

    Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1451

commit 89a40b33dd11534ab44bd840774ecb669d365b5e
Author: astroshim <hss...@nflabs.com>
Date:   2016-09-29T12:49:30Z

    change condition of parsing

commit 1d0ab93d266cc38c2758491baad6be1a3505010d
Author: astroshim <hss...@nflabs.com>
Date:   2016-09-30T02:21:21Z

    add testcase

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to