Github user spektom commented on the issue:
https://github.com/apache/zeppelin/pull/1458
Are you trying to say that people working for enterprise companies require
special input validation in addition to providing a documentation saying
that an option accepts booleans? :)
I don't think entry possible input must be validated, after all these are
Software engineers who will be seeing up Zeppelin...
On Fri, Oct 14, 2016 at 18:01 gss2002 <[email protected]> wrote:
> *@gss2002* commented on this pull request.
> ------------------------------
>
> In
> livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java
> <https://github.com/apache/zeppelin/pull/1458>:
>
> > @@ -80,7 +80,8 @@ public InterpreterResult interpret(String line,
InterpreterContext interpreterCo
> line.replaceAll("\"", "\\\\\"")
> .replaceAll("\\n", " ")
> + "\").show(" +
> - property.get("zeppelin.livy.spark.sql.maxResult") + ")",
> + property.get("zeppelin.livy.spark.sql.maxResult") + "," +
> + property.get("zeppelin.livy.spark.sql.truncateResult") +
")",
> interpreterContext, userSessionMap);
>
> @spektom <https://github.com/spektom> I hate to be the bearer of bad news
> but Zeppelin is being adopted by many Enterprises and unforuantely in most
> cases I agree that it's the users problem. But if you are going to be
> committing to software that is going to be used by large enterprises then
I
> would expect validation to occur. I am actually going to raise these
issues
> with my Hadoop vendor.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/zeppelin/pull/1458>, or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AAJpO8d402flYpiA3zkU_0nYTNaePF3Pks5qz5ksgaJpZM4KGJwn>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---