GitHub user anthonycorbacho reopened a pull request:

    https://github.com/apache/zeppelin/pull/1553

    [ZEPPELIN-1575] Notebook Repo settings UI

    ### What is this PR for?
    The idea behind this feature is to bring flexibility to the user to let him 
configure his repo via UI without restarting Apache Zeppelin.
    This is flexible enough to handle most of the basic needs, but more complex 
case can be added in the future. I will not implement all NotebookRepo, this 
should be done in different PR since it will depend on special needs. I will 
just provide a simple example with VFS notebook repo.
    
    ***NB***: this scope of the PR doesn't include save change in the 
configuration file of zeppelin as well as implementation of every notebook 
repo, git, s3 etcetc, this will be added later if needed.
    
    ### What type of PR is it?
     * **Improvement**
    
    ### Todos
    * [x] - Implement backend.
    * [x] - Implement frontend.
    * [x] - Implement LocalVFS directory change as exemple.
    
    ### What is the Jira issue?
     * [ZEPPELIN-1575](https://issues.apache.org/jira/browse/ZEPPELIN-1575)
    
    ### How should this be tested?
    Go to notebook repo setting page, edit the notebook path and save.
    
    ### Screenshots (if appropriate)
    
![notebook_repo_settings](https://cloud.githubusercontent.com/assets/3139557/19643248/583dbc2a-9a24-11e6-8f14-7deda9c443f2.gif)
    
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? NO
    * Does this needs documentation? YES


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anthonycorbacho/incubator-zeppelin 
feat/NotebookRepoSettings

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1553
    
----
commit efe4c34a5f4683161bbd06933e9010c674dd199b
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-23T04:56:08Z

    Add new Rest api endpoint for notebook Repo settings

commit a4d9749294eb8319a355cee66fb8cd3542f01624
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-23T05:02:40Z

    Added utility class for notebook re po payload deserialization

commit f7c7bf235d0d2e3e0997257dcd3c8243677f6d0c
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-23T05:03:40Z

    Update method :: updateRepoSettings to create NotebookRepoSettingsRequest 
with Empty static object instead of null

commit 054d2aa540d78217f64e7b8c32c7eba35b9afdd6
Author: Damien CORNEAU <cornead...@gmail.com>
Date:   2016-10-11T08:35:52Z

    Base structure for notebook repo ui
    
    (cherry picked from commit 6109a933daf931a50aab4352c9903b0b2db3c3c0)

commit 8075b04dc8e30d0307d1cae5975a700dfdc088a0
Author: Damien CORNEAU <cornead...@gmail.com>
Date:   2016-10-11T10:58:22Z

    Render mocked list of notebook repo settings
    
    (cherry picked from commit 26cce46d9fe6e305317fc479b49c577b5f217bb8)

commit 76479b37fc8222f48ed95c68b8133ae42533ffbe
Author: Damien CORNEAU <cornead...@gmail.com>
Date:   2016-10-12T02:37:16Z

    Change presentation of notebook settings
    
    (cherry picked from commit ba9f59bdf049a406592f721d9030d2abc8cb79b8)

commit 6a975124a2923bd9a92a2884ab05af0ab0cd9175
Author: Damien CORNEAU <cornead...@gmail.com>
Date:   2016-10-12T04:21:03Z

    Get Repos from api
    
    (cherry picked from commit 8753e05ce43187436d125d4a2a69e1744aa2e69f)

commit 9c1f99906c579ab3e9bd5c8e785e37463e5e69e5
Author: Damien CORNEAU <cornead...@gmail.com>
Date:   2016-10-16T05:28:57Z

    Implement edit
    
    (cherry picked from commit 2e09b851b019a5361ab45820a7dbd443b14cbe5a)

commit 05a64de2188cd8017864e6430dd8677fbf720107
Author: Damien CORNEAU <cornead...@gmail.com>
Date:   2016-10-16T07:41:11Z

    Improve edit repo
    
    (cherry picked from commit 37ba504aaf5fb3500cbfe1634b0722ea9107c72d)

commit 4d745ab9d39c5207012d9007628899c82af8934f
Author: Damien CORNEAU <cornead...@gmail.com>
Date:   2016-10-16T07:51:36Z

    Improve ux
    
    (cherry picked from commit f8ddfc10414f0027e5c2202839e1cdeea50d1831)

commit 30d29cd5e79b169e24a5888d84a6538dc9a61d54
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-23T05:11:47Z

    Update zeppelin server and add NotebookRepo rest api to the singleton

commit 23912ceb71112136ef02f1245eb2241b4bd9e266
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-23T05:27:52Z

    Added new wrapper class

commit 53346d71992c7f98ef9945d11b06c4be1060a087
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-23T05:34:05Z

    Add new methods in notebookRepo :: get and set settings in notebook

commit 8e890d3fec88f8af5b938a2bb2c7556f38b90451
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-23T05:36:54Z

    Add new wrapper for notebook repo PLUS settings

commit 5a13e62ae071c2f6154a8d64d3d6c3c269753098
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-23T05:40:15Z

    Added 2 new methos in notebookRepoSync, exposed get and update notebook repo

commit 2d67bc89ab8a6ce3f85346023893a34b35f6e6b2
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-23T05:41:19Z

    Added method from notebook repo interface

commit 0b4b74a0517760667a36c929d45b0b2356b95276
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-23T12:30:17Z

    Add exemple of how to change local notebook repo FS

commit dc7fc50a5993b5d485551cf6e07407e6b5a5d3c4
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-24T02:36:27Z

    Fix indentation

commit 517ebc88f5c09b03275992561ba2a9e9aba1bcf0
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-24T02:39:02Z

    Fix style

commit d49bfe138724a505579c0067500b35a840bdd35b
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-24T02:47:45Z

    Fix style

commit 357b659fc0e97528889dac8cd743baed0035886b
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-24T02:50:11Z

    Fix ASF header

commit 7fc1f37aed4e43fa570b45409612c9f2297cfe50
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-24T08:48:37Z

    Change textarea size to 100 row

commit 42fd3b5faa9b371f748a187d200d918c4ad918ec
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-24T09:22:36Z

    Apply broadcasting note list after sucessful update for notebook repo

commit 23ad18e11a370b300db16074cc3dd18740ab248e
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-24T10:01:00Z

    Rename NotebookRepoSettings to NotebookRepoSettingsInfo

commit 6f17b18639b69caefcc93e4a29aa2ea272b53f02
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-25T04:55:25Z

    Add tests :: API and REST API

commit 6d63832d8f4bdf08f79e2f7ff69fe48b4b7c0983
Author: Anthony Corbacho <corbacho.anth...@gmail.com>
Date:   2016-10-25T09:13:42Z

    Fix style and rebase mistake...

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to