GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1595
[ZEPPELIN-1615] - Zeppelin should be able to run without Shiro
### What is this PR for?
Right now, Zeppelin use Shiro by default even if you dont need it.
(It will use shiro.ini.template file if it doenst find shiro.ini), this
behaviors is a little flacky and we should start zeppelin without shiro context
if user doenst want to use it.
### What type of PR is it?
[Bug Fix | Improvement ]
### Todos
* [ ] - Update configuration - Return empty if shiro file not found
* [ ] - refactor Rest Api handler, if shiro.ini not found start a handler
without shiro context
* [ ] - refactor SecurityUtils to handle the case of shiro is disabled.
### What is the Jira issue?
* [ZEPPELIN-1615](https://issues.apache.org/jira/browse/ZEPPELIN-1615)
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anthonycorbacho/incubator-zeppelin
fix/ShiroTempleteLoginRequired
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1595.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1595
----
commit 4ceaad099dc52a3f4914d12cc20957a5e33d4af9
Author: Anthony Corbacho <[email protected]>
Date: 2016-11-04T05:22:57Z
Rework getShiroIni in zeppelinConfiguration, if shiro.ini file is not
found, then return empty instead of shiro.ini.template path
commit 48f1c502f0af4d4081cadb372b6eb668473e66a6
Author: Anthony Corbacho <[email protected]>
Date: 2016-11-04T05:24:01Z
Handle the case of user want to start zeppelin without Shiro
- Refactor handler, if not shiro ini foundm start zeppelin wihtout shiro
commit d4c13cf2aef76f26df7a7efd031124e5887f1a80
Author: Anthony Corbacho <[email protected]>
Date: 2016-11-04T05:26:55Z
Handle SecurityUtils, if shiro is disabled then script all the getPrincipla
and shiro check and return anon or empty collections in certain case
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
