GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1619
[ZEPPELIN-1647] Save roles and use for broadcasting note list per user
### What is this PR for?
So far roles have been accessible only from SecurityUtils for Rest api or
from websocket message field. However sometimes it's required to be access
roles in websocket server even with receiving message, say for broadcasting
note list per user. More details in issue.
### What type of PR is it?
Bug Fix | Improvement
### Todos
* [x] - add roles in NotebookAuthorization
* [x] - assign roles on login
* [x] - use roles on broadcast
* [ ] - test
### What is the Jira issue?
[ZEPPELIN-1647](https://issues.apache.org/jira/browse/ZEPPELIN-1647)
### How should this be tested?
login as user1, and user2 at same time and each user should have own
workbench (based on notebook permissions)
### Screenshots (if appropriate)
TBD
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin
fix/apply-correct-roles-broadcast
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1619.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1619
----
commit 4bd716922124ce89245c38f0a43fce73e00ae4b5
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-09T14:37:59Z
add roles in NotebookAuthorization
commit 83dd249f22b572bf3060c500fb3230efef1f734a
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-09T14:41:45Z
use correct roles in broadcast
commit 1baa549390f916a4a0c7b0cb04a4339dee6eddcf
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-09T14:42:36Z
set roles on login
commit 85be8b7cce16da24d0e9ab7eaa77181b91fb370c
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-09T14:43:48Z
change arg HashSet -> Set
commit d7df363cd232eeb371ee892085f4a176105a5aaf
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-09T14:44:31Z
bugfix: pass userAndRoles instead of roles
commit 260adbb7c71070e820dc40370c9ec325067e363e
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-09T14:44:54Z
remove unused import
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
