Github user bbonnin commented on the issue:
https://github.com/apache/zeppelin/pull/1598
I have just one comment: it's about some duplicate lines of codes. I think
some lines that we can find in both ElasticSearchXConnectors could be put in
the base class, in order to keep only the specific part ES v2 and V5 in the
sub-classes. An example is the method `executeDeleteQuery` that is almost the
same in both classes.
Otherwise, looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
