GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/1629

    [ZEPPELIN-1569] DON'T reset filter whenever each interpreter setting is 
updated

    ### What is this PR for?
    
    Filter is cleared whenever each interpreter setting is updated. 
    it's sometimes annoying if user wants to debugging settings (I attached GIF)
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    
    [ZEPPELIN-1659](https://issues.apache.org/jira/browse/ZEPPELIN-1659)
    
    ### How should this be tested?
    
    1. insert interpreter filter
    2. update a interpreter setting
    3. check whether the filter is cleared or not
    
    ### Screenshots (if appropriate)
    
    
![filter_is_cleared_everytime](https://cloud.githubusercontent.com/assets/4968473/20266522/c61410fa-aab9-11e6-8d1d-5e28748a7830.gif)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
fix/clear-filter-when-setting-updated

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1629.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1629
    
----
commit 72bac065e8b361ef055e1b61243531c5c2f68283
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-14T11:44:51Z

    fix: DON'T reset filter
    
    When a interpreter setting is updated

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to