[GitHub] zeppelin pull request #1638: [ZEPPELIN-1666] DON'T share mutable deps, optio...

[1ambda]

GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/1638

    [ZEPPELIN-1666] DON'T share mutable deps, options between interpreters in 
each group (bug)

    ### What is this PR for?
    
    Every interpreter shares their `List<Dependency>` and `InterpreterOption` 
object with in the same interpreter group since these objects are mutable and 
just returned from `InterpreterSettingRef` in InterpreterFactory.
    
    I attached GIF
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    
    Nothing
    
    ### What is the Jira issue?
    
    [ZEPPELIN-1666](https://issues.apache.org/jira/browse/ZEPPELIN-1666)
    
    ### How should this be tested?
    
    I included unit test for it in `InterpreterRestApiTest`
    
    ### Screenshots (if appropriate)
    
    
![duplicated_interpreter_params](https://cloud.githubusercontent.com/assets/4968473/20308094/ceeeae70-ab85-11e6-9a8e-da5bb539a03b.gif)
    
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
fix/do-not-share-deps-in-same-group

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1638
    
----
commit 74773e572b44a31b3082cd082aa4a097de9d0e63
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-15T07:58:21Z

    test: Add failing test

commit 505937ec9dc52768afca9c2098573309e32e12b0
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-15T09:17:10Z

    fix: Return immutable objects

commit 2356b5e3c7671b0ea355d5ae7e4ad7a619321350
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-15T12:59:56Z

    fix: mutable object problems in InterpreterSetting
    
    By filling InterpreterSetting object by newly created objects

commit 0d91279fb4c8912be520b282ab9bf658e58c8b55
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-15T13:09:00Z

    style: Reindent using zeppelin's checkstyle xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---