GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1689
[ZEPPELIN-1709] Update checkstyle rule file, plugin
### What is this PR for?
We have
- outdated checkstyle.xml
- old maven checkstyle plugin
- no detailed style plugin guide (e.g available plugins, how to use them in
your IDEA)
By fixing those issues, we can keep our code clean. It will results the
number of rebase count (reduced conflict due to just style) and boost our
productivity.
**important note**
This PR set an option to print all checkstyle warnings into stdout.
The reason is, people should be told about invalid styles of not only
errors but also warnings.
Once those warnings are all fixed, we can set
`<violationSeverity>warning</violationSeverity>` to fail build even when
checkstyle warning is occurred.
By doing that, we can make our code more consistent.
```xml
<consoleOutput>true</consoleOutput>
<!-- TODO: <violationSeverity>warning</violationSeverity> -->
```
### What type of PR is it?
[Improvement]
### Todos
* [x] - update check style plugin
* [x] - update checkstyle.xml
* [x] - fix some styles
* [x] - print checkstyle WARN
### What is the Jira issue?
[ZEPPELIN-1709](https://issues.apache.org/jira/browse/ZEPPELIN-1709)
### How should this be tested?
```
mvn validate -Denforcer.skip=true
```
### Questions:
* Does the licenses files need update - NO
* Is there breaking changes for older versions - NO
* Does this needs documentation - NO, but I added some docs about how to
use checkstyle.xml in IDEA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin feat/update-checkstyle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1689.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1689
----
commit 46c59bae0daf38df9dae39203632f0d7a2c8d6d1
Author: 1ambda <[email protected]>
Date: 2016-11-28T02:27:18Z
chore: Use pluginManagement block
so that config be shared in children projects
commit 2fa6f734a1176a35f0cec7a440e0f992fb781cdb
Author: 1ambda <[email protected]>
Date: 2016-11-28T02:28:29Z
chore: Remove useless failOnViolation config
its default value is already `true`
see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html
commit 1988d41f26c20b1633963abd5ea93d35d7007f4b
Author: 1ambda <[email protected]>
Date: 2016-11-28T02:29:46Z
chore: Remove duplicated exclude
commit 83e0c7b0d75b52cee695f186ef9743bbc575e31d
Author: 1ambda <[email protected]>
Date: 2016-11-28T02:13:15Z
chore: Update checkstyle version
commit 70b15c9b0d231ec4a12cc01e889e8ed1d75ad828
Author: 1ambda <[email protected]>
Date: 2016-11-28T02:52:15Z
style: Fix Invalid indents in interpreter
[INFO]
------------------------------------------------------------------------
[INFO] Building Zeppelin: Interpreter 0.7.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @
zeppelin-interpreter ---
[INFO] There are 5 errors reported by Checkstyle 6.11.2 with
_tools/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/zeppelin/dep/DependencyResolver.java:[162]
(indentation) Indentation: 'Collection' have incorrect indentation level 4,
expected level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:[242]
(indentation) Indentation: 'getClassName' have incorrect indentation level 10,
expected level should be 12.
[ERROR]
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[59]
(indentation) Indentation: 'extends' have incorrect indentation level 2,
expected level should be 4.
[ERROR]
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[60]
(indentation) Indentation: 'implements' have incorrect indentation level 2,
expected level should be 4.
[ERROR] src/test/resources/log4j.properties:[0] (misc) NewlineAtEndOfFile:
File does not end with a newline.
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [
3.587 s]
[INFO] Zeppelin: Interpreter .............................. FAILURE [
0.901 s]
commit 6f0d72fb281c04bd44e839adc08cfbcd4dd9654e
Author: 1ambda <[email protected]>
Date: 2016-11-28T03:03:06Z
style: Fix invalid indents in zengine
[INFO]
------------------------------------------------------------------------
[INFO] Building Zeppelin: Zengine 0.7.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @
zeppelin-zengine ---
[INFO] There are 13 errors reported by Checkstyle 6.11.2 with
_tools/checkstyle.xml ruleset.
[ERROR]
src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java:[348]
(indentation) Indentation: '.' have incorrect indentation level 5, expected
level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java:[412]
(indentation) Indentation: '"Information From loaded Interpreter Setting Ref -
{} "' have incorrect indentation level10, expected level should be 12.
[ERROR]
src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[37]
(indentation) Indentation: 'array initialization' child have incorrect
indentation level 4, expected level shouldbe 6.
[ERROR]
src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[38]
(indentation) Indentation: 'array initialization' child have incorrect
indentation level 4, expected level shouldbe 6.
[ERROR]
src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[39]
(indentation) Indentation: 'array initialization' child have incorrect
indentation level 4, expected level shouldbe 6.
[ERROR]
src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[44]
(indentation) Indentation: 'JsonDeserializationContext' have incorrect
indentation level 4, expected level shouldbe 6.
[ERROR] src/main/java/org/apache/zeppelin/notebook/Paragraph.java:[229]
(indentation) Indentation: '&&' have incorrect indentation level 6, expected
level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/notebook/Paragraph.java:[230]
(indentation) Indentation: '&&' have incorrect indentation level 6, expected
level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/notebook/Paragraph.java:[306]
(indentation) Indentation: 'interpreterHasUser' have incorrect indentation
level 8, expected level should be 10.
[ERROR] src/main/java/org/apache/zeppelin/notebook/Paragraph.java:[307]
(indentation) Indentation: 'isUserAuthorizedToAccessInterpreter' have incorrect
indentation level 8, expected level should be 10.
[ERROR]
src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepoSync.java:[440]
(indentation) Indentation: 'getRepo' have incorrect indentation level 10,
expected level should be 12.
[ERROR]
src/main/java/org/apache/zeppelin/notebook/utility/IdHashes.java:[30]
(indentation) Indentation: 'array initialization' child have incorrect
indentation level 4, expected level should be one ofthe following: 6, 55, 58.
[ERROR]
src/main/java/org/apache/zeppelin/notebook/utility/IdHashes.java:[31]
(indentation) Indentation: 'array initialization' child have incorrect
indentation level 4, expected level should be one ofthe following: 6, 55, 58.
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [
3.116 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [
1.237 s]
[INFO] Zeppelin: Zengine .................................. FAILURE [
0.612 s]
commit 30e0a3243d51b1a9e006949fa4b044141c7db54c
Author: 1ambda <[email protected]>
Date: 2016-11-28T03:08:36Z
chore: Use recent checkstyle runtime
commit a902958aec0f6a889253b67a848633bd7e2e49e7
Author: 1ambda <[email protected]>
Date: 2016-11-28T03:11:54Z
style: Fix indents in spark
[INFO]
------------------------------------------------------------------------
[INFO] Building Zeppelin: Spark 0.7.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @
zeppelin-spark_2.10 ---
[INFO] There are 10 errors reported by Checkstyle 6.19 with
_tools/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/zeppelin/spark/DepInterpreter.java:[209]
(indentation) Indentation:'intp' have incorrect indentation level 6, expected
level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[418]
(indentation) Indentation: 'e' have incorrect indentation level 10, expected
level should be 12.
[ERROR] src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[493]
(indentation) Indentation: 'array initialization' child have incorrect
indentation level 6, expected level should be one of the following: 8, 39, 42.
[ERROR]
src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1158]
(indentation) Indentation: '||' have incorrect indentation level 11, expected
level should be 12.
[ERROR]
src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1159]
(indentation) Indentation: '||' have incorrect indentation level 11, expected
level should be 12.
[ERROR]
src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1160]
(indentation) Indentation: '||' have incorrect indentation level 11, expected
level should be 12.
[ERROR]
src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1451]
(indentation) Indentation: 'array initialization' child have incorrect
indentation level 12, expected level should be 14.
[ERROR]
src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1454]
(indentation) Indentation: 'array initialization' child have incorrect
indentation level 8, expected level should be 10.
[ERROR]
src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1463]
(indentation) Indentation: 'array initialization' child have incorrect
indentation level 14, expected level should be 16.
[ERROR]
src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1465]
(indentation) Indentation: 'array initialization' child have incorrect
indentation level 10, expected level should be 12.
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [
3.472 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [
1.153 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [
0.867 s]
[INFO] Zeppelin: Display system apis ...................... SUCCESS [
0.214 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [
0.644 s]
[INFO] Zeppelin: Spark .................................... FAILURE [
0.348 s]
commit 899b13d55198f85a7ea77af71ef17f29249e3f8e
Author: 1ambda <[email protected]>
Date: 2016-11-28T03:18:19Z
style: Fix indents in shell
[INFO]
------------------------------------------------------------------------
[INFO] Building Zeppelin: Shell interpreter 0.7.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @
zeppelin-shell ---
[INFO] There are 5 errors reported by Checkstyle 6.19 with
_tools/checkstyle.xml ruleset.
[ERROR]
src/main/java/org/apache/zeppelin/shell/security/ShellSecurityImpl.java:[39]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/shell/security/ShellSecurityImpl.java:[46]
(indentation) Indentation: 'properties' have incorrect indentation level 12,
expected level should be 14.
[ERROR]
src/main/java/org/apache/zeppelin/shell/security/ShellSecurityImpl.java:[47]
(indentation) Indentation: 'properties' have incorrect indentation level 12,
expected level should be 14.
[ERROR] src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java:[94]
(indentation) Indentation: '+' have incorrect indentation level 8, expected
level should be 10.
[ERROR] src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java:[105]
(indentation) Indentation: '+' have incorrect indentation level 10, expected
level should be 12.
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [
3.454 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [
1.074 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [
0.889 s]
[INFO] Zeppelin: Display system apis ...................... SUCCESS [
0.173 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [
0.723 s]
[INFO] Zeppelin: Spark .................................... SUCCESS [
0.640 s]
[INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [
0.181 s]
[INFO] Zeppelin: Angular interpreter ...................... SUCCESS [
0.135 s]
[INFO] Zeppelin: Shell interpreter ........................ FAILURE [
0.135 s]
commit 98108bab2f163857ad00a2ad49890438f497b9d5
Author: 1ambda <[email protected]>
Date: 2016-11-28T03:25:15Z
style: Fix indents in jdbc
[INFO]
------------------------------------------------------------------------
[INFO] Building Zeppelin: JDBC interpreter 0.7.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @
zeppelin-jdbc ---
[INFO] There are 6 errors reported by Checkstyle 6.19 with
_tools/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:[259]
(indentation) Indentation:'jdbcUserConfigurationsMap' have incorrect
indentation level 6, expected level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:[282]
(indentation) Indentation:'getJDBCConfiguration' have incorrect indentation
level 6, expected level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:[291]
(indentation) Indentation:'getEntityName' have incorrect indentation level 6,
expected level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:[302]
(indentation) Indentation:'new' have incorrect indentation level 6, expected
level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:[305]
(indentation) Indentation:'connectionFactory' have incorrect indentation level
6, expected level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:[532]
(indentation) Indentation:'getJDBCConfiguration' have incorrect indentation
level 6, expected level should be 8.
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [
3.206 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [
1.011 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [
0.778 s]
[INFO] Zeppelin: Display system apis ...................... SUCCESS [
0.175 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [
0.481 s]
[INFO] Zeppelin: Spark .................................... SUCCESS [
0.365 s]
[INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [
0.160 s]
[INFO] Zeppelin: Angular interpreter ...................... SUCCESS [
0.142 s]
[INFO] Zeppelin: Shell interpreter ........................ SUCCESS [
0.142 s]
[INFO] Zeppelin: Livy interpreter ......................... SUCCESS [
0.476 s]
[INFO] Zeppelin: HBase interpreter ........................ SUCCESS [
0.272 s]
[INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [
0.224 s]
[INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [
0.200 s]
[INFO] Zeppelin: JDBC interpreter ......................... FAILURE [
0.186 s]
commit 59f5ecf4136f664fac83bab231cbd8490ecb52b9
Author: 1ambda <[email protected]>
Date: 2016-11-28T03:28:35Z
style: Fix indents in lens
[INFO]
------------------------------------------------------------------------
[INFO] Building Zeppelin: Lens interpreter 0.7.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @
zeppelin-lens ---
[INFO] There are 18 errors reported by Checkstyle 6.19 with
_tools/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[79]
(indentation) Indentation: 'new' have incorrect indentation level 4, expected
level should be 6.
[ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[81]
(indentation) Indentation: 'new' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[103,37]
(whitespace) WhitespaceAround: '|' is not preceded with whitespace.
[ERROR]
src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[103,38]
(whitespace) WhitespaceAround: '|' is not followed by whitespace.
[ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[106]
(indentation) Indentation:'+' have incorrect indentation level 10, expected
level should be 12.
[ERROR]
src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[110,37]
(whitespace) WhitespaceAround: '|' is not preceded with whitespace.
[ERROR]
src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[110,38]
(whitespace) WhitespaceAround: '|' is not followed by whitespace.
[ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[269]
(indentation) Indentation:'new' have incorrect indentation level 10, expected
level should be 12.
[ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[272]
(indentation) Indentation:'+' have incorrect indentation level 10, expected
level should be 12.
[ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[324]
(indentation) Indentation:'result' have incorrect indentation level 6, expected
level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[351]
(indentation) Indentation:'+' have incorrect indentation level 8, expected
level should be 10.
[ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[354]
(indentation) Indentation:'+' have incorrect indentation level 8, expected
level should be 10.
[ERROR]
src/main/java/org/apache/zeppelin/lens/LensJLineShellComponent.java:[41]
(indentation) Indentation: 'implements' have incorrect indentation level 2,
expected level should be 4.
[ERROR]
src/main/java/org/apache/zeppelin/lens/LensJLineShellComponent.java:[105]
(indentation) Indentation: 'BeanFactoryUtils' have incorrect indentation level
6, expected level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/lens/LensJLineShellComponent.java:[112]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/lens/LensJLineShellComponent.java:[172]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/lens/LensJLineShellComponent.java:[189]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/lens/LensJLineShellComponent.java:[209]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [
3.334 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [
1.060 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [
0.781 s]
[INFO] Zeppelin: Display system apis ...................... SUCCESS [
0.184 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [
0.514 s]
[INFO] Zeppelin: Spark .................................... SUCCESS [
0.388 s]
[INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [
0.155 s]
[INFO] Zeppelin: Angular interpreter ...................... SUCCESS [
0.133 s]
[INFO] Zeppelin: Shell interpreter ........................ SUCCESS [
0.133 s]
[INFO] Zeppelin: Livy interpreter ......................... SUCCESS [
0.438 s]
[INFO] Zeppelin: HBase interpreter ........................ SUCCESS [
0.256 s]
[INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [
0.269 s]
[INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [
0.165 s]
[INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [
0.200 s]
[INFO] Zeppelin: File System Interpreters ................. SUCCESS [
0.170 s]
[INFO] Zeppelin: Flink .................................... SUCCESS [
0.241 s]
[INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [
0.173 s]
[INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [
0.141 s]
[INFO] Zeppelin: Python interpreter ....................... SUCCESS [
0.188 s]
[INFO] Zeppelin: Lens interpreter ......................... FAILURE [
0.260 s]
commit bf19d175d63e4cc3b0f192c539ffd24f2f082e57
Author: 1ambda <[email protected]>
Date: 2016-11-28T03:31:09Z
style: Fix indents in elasticsearch
[INFO]
------------------------------------------------------------------------
[INFO] Building Zeppelin: Elasticsearch interpreter 0.7.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @
zeppelin-elasticsearch ---
[INFO] There are 30 errors reported by Checkstyle 6.19 with
_tools/checkstyle.xml ruleset.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[80]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[81]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[82]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[83]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[84]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[85]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[86]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[87]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[88]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[89]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[90]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[91]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[92]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[93]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[94]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[95]
(indentation) Indentation: '+' have incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[98]
(indentation) Indentation: '"count"' have incorrect indentation level 4,
expected level should be 6.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[125]
(indentation) Indentation: 'property' have incorrect indentation level 8,
expected level should be 10.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[134]
(indentation) Indentation: '.' have incorrect indentation level 8, expected
level should be 10.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[135]
(indentation) Indentation: '.' have incorrect indentation level 8, expected
level should be 10.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[136]
(indentation) Indentation: '.' have incorrect indentation level 8, expected
level should be 10.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[283]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[284]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[354]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[355]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[356]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[381]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[382]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[397]
(indentation) Indentation: 'client' have incorrect indentation level 6,
expected level should be 8.
[ERROR]
src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[513]
(indentation) Indentation: 'flattenJsonMap' have incorrect indentation level
12, expected level should be 14.
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [
3.534 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [
1.155 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [
0.954 s]
[INFO] Zeppelin: Display system apis ...................... SUCCESS [
0.185 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [
0.617 s]
[INFO] Zeppelin: Spark .................................... SUCCESS [
0.410 s]
[INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [
0.168 s]
[INFO] Zeppelin: Angular interpreter ...................... SUCCESS [
0.149 s]
[INFO] Zeppelin: Shell interpreter ........................ SUCCESS [
0.154 s]
[INFO] Zeppelin: Livy interpreter ......................... SUCCESS [
0.645 s]
[INFO] Zeppelin: HBase interpreter ........................ SUCCESS [
0.258 s]
[INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [
0.211 s]
[INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [
0.174 s]
[INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [
0.211 s]
[INFO] Zeppelin: File System Interpreters ................. SUCCESS [
0.176 s]
[INFO] Zeppelin: Flink .................................... SUCCESS [
0.235 s]
[INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [
0.174 s]
[INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [
0.152 s]
[INFO] Zeppelin: Python interpreter ....................... SUCCESS [
0.181 s]
[INFO] Zeppelin: Lens interpreter ......................... SUCCESS [
0.319 s]
[INFO] Zeppelin: Apache Cassandra interpreter ............. SUCCESS [
0.276 s]
[INFO] Zeppelin: Elasticsearch interpreter ................ FAILURE [
0.236 s]
commit e80dd941c06a180be42aaa195a325c343f2aafa3
Author: 1ambda <[email protected]>
Date: 2016-11-28T03:32:18Z
style: Fix indents in bigquery
[INFO]
------------------------------------------------------------------------
[INFO] Building Zeppelin: BigQuery interpreter 0.7.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @
zeppelin-bigquery ---
[INFO] There is 1 error reported by Checkstyle 6.19 with
_tools/checkstyle.xml ruleset.
[ERROR]
src/main/java/org/apache/zeppelin/bigquery/BigQueryInterpreter.java:[267]
(indentation) Indentation: 'final' have incorrect indentation level 4, expected
level should be 6.
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [
3.719 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [
1.440 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [
1.008 s]
[INFO] Zeppelin: Display system apis ...................... SUCCESS [
0.219 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [
0.587 s]
[INFO] Zeppelin: Spark .................................... SUCCESS [
0.416 s]
[INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [
0.170 s]
[INFO] Zeppelin: Angular interpreter ...................... SUCCESS [
0.152 s]
[INFO] Zeppelin: Shell interpreter ........................ SUCCESS [
0.143 s]
[INFO] Zeppelin: Livy interpreter ......................... SUCCESS [
0.464 s]
[INFO] Zeppelin: HBase interpreter ........................ SUCCESS [
0.238 s]
[INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [
0.199 s]
[INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [
0.199 s]
[INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [
0.216 s]
[INFO] Zeppelin: File System Interpreters ................. SUCCESS [
0.175 s]
[INFO] Zeppelin: Flink .................................... SUCCESS [
0.211 s]
[INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [
0.177 s]
[INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [
0.141 s]
[INFO] Zeppelin: Python interpreter ....................... SUCCESS [
0.164 s]
[INFO] Zeppelin: Lens interpreter ......................... SUCCESS [
0.272 s]
[INFO] Zeppelin: Apache Cassandra interpreter ............. SUCCESS [
0.211 s]
[INFO] Zeppelin: Elasticsearch interpreter ................ SUCCESS [
0.214 s]
[INFO] Zeppelin: BigQuery interpreter ..................... FAILURE [
0.159 s]
commit 4194338e585b2b94dbb8230c1bc920534a212893
Author: 1ambda <[email protected]>
Date: 2016-11-28T03:34:48Z
style: Fix indents in alluxio
[INFO]
------------------------------------------------------------------------
[INFO] Building Zeppelin: Alluxio interpreter 0.7.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @
zeppelin-alluxio ---
[INFO] There is 1 error reported by Checkstyle 6.19 with
_tools/checkstyle.xml ruleset.
[ERROR]
src/main/java/org/apache/zeppelin/alluxio/AlluxioInterpreter.java:[74]
(indentation) Indentation: '" on port "' have incorrect indentation level 6,
expected level should be 8.
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [
3.176 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [
1.072 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [
0.946 s]
[INFO] Zeppelin: Display system apis ...................... SUCCESS [
0.168 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [
0.633 s]
[INFO] Zeppelin: Spark .................................... SUCCESS [
0.435 s]
[INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [
0.168 s]
[INFO] Zeppelin: Angular interpreter ...................... SUCCESS [
0.145 s]
[INFO] Zeppelin: Shell interpreter ........................ SUCCESS [
0.137 s]
[INFO] Zeppelin: Livy interpreter ......................... SUCCESS [
0.602 s]
[INFO] Zeppelin: HBase interpreter ........................ SUCCESS [
0.338 s]
[INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [
0.275 s]
[INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [
0.177 s]
[INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [
0.221 s]
[INFO] Zeppelin: File System Interpreters ................. SUCCESS [
0.174 s]
[INFO] Zeppelin: Flink .................................... SUCCESS [
0.315 s]
[INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [
0.215 s]
[INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [
0.144 s]
[INFO] Zeppelin: Python interpreter ....................... SUCCESS [
0.191 s]
[INFO] Zeppelin: Lens interpreter ......................... SUCCESS [
0.285 s]
[INFO] Zeppelin: Apache Cassandra interpreter ............. SUCCESS [
0.276 s]
[INFO] Zeppelin: Elasticsearch interpreter ................ SUCCESS [
0.295 s]
[INFO] Zeppelin: BigQuery interpreter ..................... SUCCESS [
0.172 s]
[INFO] Zeppelin: Alluxio interpreter ...................... FAILURE [
0.212 s]
commit 20bc61414472570ee334c2d006a71f80015ca580
Author: 1ambda <[email protected]>
Date: 2016-11-28T03:46:42Z
style: Fix indents in server
[INFO]
------------------------------------------------------------------------
[INFO] Building Zeppelin: Server 0.7.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
Downloading:
http://repository.apache.org/snapshots/org/apache/zeppelin/zeppelin-zengine/0.7.0-SNAPSHOT/maven-metadata.xml
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @
zeppelin-server ---
[INFO] There are 18 errors reported by Checkstyle 6.19 with
_tools/checkstyle.xml ruleset.
[ERROR]
src/main/java/org/apache/zeppelin/realm/ActiveDirectoryGroupRealm.java:[120]
(indentation) Indentation: 'this' have incorrect indentation level 10, expected
level should be 12.
[ERROR]
src/main/java/org/apache/zeppelin/realm/ActiveDirectoryGroupRealm.java:[122]
(indentation) Indentation: 'CredentialProviderFactory' have incorrect
indentation level 10, expected level should be12.
[ERROR] src/main/java/org/apache/zeppelin/rest/CredentialRestApi.java:[69]
(indentation) Indentation: 'new' have incorrect indentation level 6, expected
level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/server/ZeppelinServer.java:[319]
(indentation) Indentation: '=' have incorrect indentation level 6, expected
level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[474]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[481]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[498]
(indentation) Indentation: 'new' have incorrect indentation level 6, expected
level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1178]
(indentation) Indentation: 'String' have incorrect indentation level 5,
expected level should be 6.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1179]
(indentation) Indentation: 'String' have incorrect indentation level 5,
expected level should be 6.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1194]
(indentation) Indentation: 'String' have incorrect indentation level 4,
expected level should be 6.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1195]
(indentation) Indentation: 'String' have incorrect indentation level 4,
expected level should be 6.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1208]
(indentation) Indentation: 'Object' have incorrect indentation level 4,
expected level should be 6.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1209]
(indentation) Indentation: 'String' have incorrect indentation level 4,
expected level should be 6.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1227]
(indentation) Indentation: 'AngularObjectRegistry' have incorrect indentation
level 4, expected level should be 6.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1330]
(indentation) Indentation: '.' have incorrect indentation level 7, expected
level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1333]
(indentation) Indentation: '.' have incorrect indentation level 7, expected
level should be 8.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1399]
(indentation) Indentation: '.' have incorrect indentation level 8, expected
level should be 10.
[ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1410]
(indentation) Indentation: '.' have incorrect indentation level 6, expected
level should be 8.
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [
3.445 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [
1.333 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [
1.078 s]
[INFO] Zeppelin: Display system apis ...................... SUCCESS [
0.183 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [
0.541 s]
[INFO] Zeppelin: Spark .................................... SUCCESS [
0.388 s]
[INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [
0.158 s]
[INFO] Zeppelin: Angular interpreter ...................... SUCCESS [
0.139 s]
[INFO] Zeppelin: Shell interpreter ........................ SUCCESS [
0.184 s]
[INFO] Zeppelin: Livy interpreter ......................... SUCCESS [
0.630 s]
[INFO] Zeppelin: HBase interpreter ........................ SUCCESS [
0.293 s]
[INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [
0.263 s]
[INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [
0.213 s]
[INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [
0.269 s]
[INFO] Zeppelin: File System Interpreters ................. SUCCESS [
0.208 s]
[INFO] Zeppelin: Flink .................................... SUCCESS [
0.243 s]
[INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [
0.169 s]
[INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [
0.163 s]
[INFO] Zeppelin: Python interpreter ....................... SUCCESS [
0.256 s]
[INFO] Zeppelin: Lens interpreter ......................... SUCCESS [
0.387 s]
[INFO] Zeppelin: Apache Cassandra interpreter ............. SUCCESS [
0.269 s]
[INFO] Zeppelin: Elasticsearch interpreter ................ SUCCESS [
0.225 s]
[INFO] Zeppelin: BigQuery interpreter ..................... SUCCESS [
0.154 s]
[INFO] Zeppelin: Alluxio interpreter ...................... SUCCESS [
0.225 s]
[INFO] Zeppelin: Scio ..................................... SUCCESS [
0.369 s]
[INFO] Zeppelin: web Application .......................... SUCCESS [
1.602 s]
[INFO] Zeppelin: Server ................................... FAILURE [
1.983 s]
commit 645bf8bc57e28b504f5d8c65b0abac3944dee01e
Author: 1ambda <[email protected]>
Date: 2016-11-28T04:21:49Z
chore: Update checkstyle.xml versio to 6.19
https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-6.19/src/main/resources/google_checks.xml
commit 1f452635cac0cb7750e905bb322c57c26e707a22
Author: 1ambda <[email protected]>
Date: 2016-11-28T04:32:05Z
fix: Exclude checkstyle target properly
- Exclude targets in its own pom.xml instead of in parent's pom.xml
commit f3f488c84eb84f485b88791e098a74d942d5dfca
Author: 1ambda <[email protected]>
Date: 2016-11-28T04:49:31Z
fix: Print checkstyle WARN
so that people get aware of it, make move to fix it
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
